Ceph OSD Charm

bcache symlinks get broken when using udev dname

Bug #1790186 reported by Gábor Mészáros
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceph OSD Charm
Fix Released
Medium
Unassigned
Ceph OSD Charm 19.04
charms.ceph
Fix Released
Undecided
Unassigned

Bug Description

specifying osd devices = '/dev/disk/by-dname/bcache-osd0' is broken, due to the underlying ceph-disk prepare will call sgdisk, which intermittently removes the symlink and the next command is in race with the recreation of the symlink.

Tags: 4010
Gábor Mészáros (gabor.meszaros)
tags: added: 400
tags: added: 4001
removed: 400
tags: added: 4010
removed: 4001
Revision history for this message
Gábor Mészáros (gabor.meszaros) wrote :

https://review.openstack.org/#/c/599038/2

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charms.ceph (master)

Reviewed: https://review.openstack.org/599038
Committed: https://git.openstack.org/cgit/openstack/charms.ceph/commit/?id=412612a2861bcbb46059b706bde788eed0e62b87
Submitter: Zuul
Branch: master

commit 412612a2861bcbb46059b706bde788eed0e62b87
Author: Gabor Meszaros <email address hidden>
Date: Fri Aug 31 19:21:59 2018 +0200

    Provide the real path of device for ceph to prepare

    This is a followup patch for the previous commits that are
    addressing issues with bcache based configuration.

    Providing dname path for ceph-disk is unsafe, the prepare command
    uses gdisk which breaks the dname symlinks.

    Change-Id: Id3f360c90d40b77720d7bc7c1bf94b79f71b6827
    Closes-Bug: 1790186
    Signed-off-by: Gabor Meszaros <email address hidden>

Changed in charms.ceph:
status: New → Fix Released
James Page (james-page)
Changed in charm-ceph-osd:
status: New → Fix Committed
importance: Undecided → Medium
David Ames (thedac)
Changed in charm-ceph-osd:
milestone: none → 19.04
David Ames (thedac)
Changed in charm-ceph-osd:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on charm-ceph-osd (master)

Change abandoned by Gábor Mészáros (<email address hidden>) on branch: master
Review: https://review.opendev.org/599033

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.