[18.05] zap-disk action doesn't re-trigger osdizing

[Dmitrii Shcherbakov]

If a device was considered non-pristine due to some old data and zap-disk was called to resolve this the charm status remains the same and there is no retry in adding a new osd.

juju run-action ceph-osd/3 zap-disk devices=/dev/sdb i-really-mean-it=true

ceph-osd/3 blocked idle 3 10.232.24.6 Non-pristine devices detected, consult `list-disks`, `zap-disk` and `blacklist-*` actions.

Restarting a unit agent triggers config-changed which allows

sudo systemctl restart jujud-unit-ceph-osd-3
juju show-status-log ceph-osd/3
Time Type Status Message
08 Aug 2018 20:42:48-04:00 juju-unit executing running mon-relation-joined hook
08 Aug 2018 20:43:17-04:00 juju-unit executing running mon-relation-changed hook
08 Aug 2018 20:43:20-04:00 workload waiting Incomplete relation: monitor
08 Aug 2018 20:43:20-04:00 juju-unit idle
08 Aug 2018 20:45:23-04:00 juju-unit executing running mon-relation-changed hook
08 Aug 2018 20:46:02-04:00 juju-unit idle
08 Aug 2018 20:50:07-04:00 juju-unit executing running mon-relation-changed hook
08 Aug 2018 20:50:16-04:00 workload blocked Non-pristine devices detected, consult `list-disks`, `zap-disk` and `blacklist-*` actions.
08 Aug 2018 20:50:18-04:00 juju-unit idle
09 Aug 2018 02:03:36-04:00 juju-unit executing running action zap-disk
09 Aug 2018 02:03:39-04:00 juju-unit idle
09 Aug 2018 02:04:01-04:00 juju-unit executing running action list-disks
09 Aug 2018 02:04:02-04:00 juju-unit idle
09 Aug 2018 02:04:46-04:00 juju-unit executing running action zap-disk # <- tried zapping again as the status has not changed
09 Aug 2018 02:04:49-04:00 juju-unit idle
09 Aug 2018 02:05:17-04:00 juju-unit executing running leader-settings-changed hook # <-restarted the unit agent
09 Aug 2018 02:05:17-04:00 juju-unit executing running config-changed hook
09 Aug 2018 02:05:28-04:00 workload maintenance Initializing device /dev/sdb
09 Aug 2018 02:05:36-04:00 juju-unit idle
09 Aug 2018 02:10:12-04:00 workload active Unit is ready (1 OSD)

[Frode Nordahl (fnordahl)]

This is working as intended and documented here: https://docs.openstack.org/charm-guide/latest/1805.html#ceph-osd-automatic-reformatting-of-osd-devices

You must run add-disk action after zap-disk action (or trigger other charm event) to have ceph-osd charm osdize it.

[Dmitrii Shcherbakov (dmitriis)]

Thanks, I can try that out.