customize-failure-domain with "juju_availability_zone" is not reflected into crushmap

Bug #1684330 reported by Nobuto Murata
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Ceph OSD Charm
Fix Released
High
Dmitrii Shcherbakov

Bug Description

[juju debug-log -i unit-ceph-osd-0 --replay]
unit-ceph-osd-0: 15:34:29 INFO unit.ceph-osd/0.juju-log mon:63: AZ Info: juju_availability_zone=zone-rack01

[/etc/ceph/ceph.conf]
osd crush location = root=default juju_availability_zone=zone-rack01 host=node01

However, I cannot find any rack or juju_availability_zone related entries in crushmap. juju_availability_zone instead of "rack" is a valid type in crushmap?

$ sudo ceph osd getcrushmap | crushtool -d -
# types
type 0 osd
type 1 host
type 2 chassis
type 3 rack
type 4 row
type 5 pdu
type 6 pod
type 7 room
type 8 datacenter
type 9 region
type 10 root
...
host node01 {
...

Tags: cpec
Nobuto Murata (nobuto)
summary: - customize-failure-domain with "juju_availability_zone" is not a valid
- type
+ customize-failure-domain with "juju_availability_zone" is not reflected
+ into crushmap
Revision history for this message
Tom-Erik Røberg (tom-erik-roberg) wrote :

I'm seeing the same thing with charm version 241.
It worked before in an earlier version of the charm. I don't remember which version.

Revision history for this message
Chris Holcombe (xfactor973) wrote :

So from what I've seen in the past not all the available clouds support this feature. Which cloud were you deploying to? It seems to work fine with maas and ec2. I don't know about the others.

Revision history for this message
Nobuto Murata (nobuto) wrote :

I used MAAS 2.1 and juju 2.1 from stable PPAs.

Revision history for this message
Sandor Zeestraten (szeestraten) wrote :

Answering for @tom-erik-roberg here.

We use MAAS 2.1.3 and Juju 2.1.2

Revision history for this message
Sandor Zeestraten (szeestraten) wrote :

Also, could you clarify the functionality as it seems that there also is a customize-failure-domain flag on the ceph-mon charm? Is expected to be set for both ceph-osd and ceph-mon?

Revision history for this message
Sandor Zeestraten (szeestraten) wrote :

The issue seems to be introduced in https://review.openstack.org/#/c/409318/

The line in https://github.com/openstack/charm-ceph-osd/commit/877232630ad002c658d60948916af57b6d34fb5d#diff-9bb63b127ff9b4717f77c840a30821d3R196 seems to be the offender here if you only have customize-failure-domain set.

As @nobuto mentioned, juju_availability_zone is not a valid crushmap type so I'm not sure of what the intention here is.

See patch for a fix that reverts to use rack as the default type for juju availability zones when only having customize-failure-domain set to true.

I can create a change on review.openstack.org if that seems OK.

tags: added: cpec
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-ceph-osd (master)

Reviewed: https://review.openstack.org/498367
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-osd/commit/?id=3c6aec6aca9b5457276a3ae6404c6a8e33ecd424
Submitter: Jenkins
Branch: master

commit 3c6aec6aca9b5457276a3ae6404c6a8e33ecd424
Author: Dmitrii Shcherbakov <email address hidden>
Date: Mon Aug 28 11:26:35 2017 +0300

    fix JUJU_AVAILABILITY_ZONE usage

    juju_availability_zone is not a valid configuration setting, let's use
    'rack' instead.

    Change-Id: I6763377f253e6feb92d7c4c31eefc600cce3a8b8
    Closes-Bug: #1684330

Changed in charm-ceph-osd:
status: New → Fix Committed
Revision history for this message
Sandor Zeestraten (szeestraten) wrote :

@dmitriis, do you know if this will be out for the 17.08 release?

Revision history for this message
Chris MacNaughton (chris.macnaughton) wrote :

This fix has been merged so should go out with the next (17.08) charm release.

James Page (james-page)
Changed in charm-ceph-osd:
importance: Undecided → High
James Page (james-page)
Changed in charm-ceph-osd:
milestone: none → 17.08
James Page (james-page)
Changed in charm-ceph-osd:
status: Fix Committed → Fix Released
Changed in charm-ceph-osd:
assignee: nobody → Dmitrii Shcherbakov (dmitriis)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.