action - create-pool - profile-name ignored for replicated pools

Bug #1905573 reported by James Page
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ceph Monitor Charm
Fix Released
Undecided
Aqsa Malik
Pacific
Fix Released
Undecided
Unassigned

Bug Description

create pool has a profile name that should allow a pool to be created with a CRUSH profile other than the default replicated rule.

create-pool:
  description: "Creates a pool"
  params:
    name:
      type: string
      description: "The name of the pool"
    app-name:
      type: string
      description: "App name to set on the newly created pool."
    profile-name:
      type: string
      description: "The crush profile to use for this pool. The ruleset must exist first."

however its ignored on pool creation

Aqsa Malik (aqsamm)
Changed in charm-ceph-mon:
assignee: nobody → Aqsa Malik (aqsamm)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-ceph-mon (master)
Changed in charm-ceph-mon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-ceph-mon (master)

Reviewed: https://review.opendev.org/c/openstack/charm-ceph-mon/+/827862
Committed: https://opendev.org/openstack/charm-ceph-mon/commit/da798bdd95f8fa19ce42363be6bfb268d62fe690
Submitter: "Zuul (22348)"
Branch: master

commit da798bdd95f8fa19ce42363be6bfb268d62fe690
Author: Aqsa Malik <email address hidden>
Date: Fri Feb 4 13:06:53 2022 +0100

    Add profile-name parameter in create-pool action

    This change adds a profile name parameter in the create-pool action that
    allows a replicated pool to be created with a CRUSH profile other than
    the default replicated_rule.

    Closes-Bug: #1905573

    Change-Id: Ib21ded8f4a977b4a2d57c6b6b4bb82721b12c4ea

Changed in charm-ceph-mon:
status: In Progress → Fix Committed
Changed in charm-ceph-mon:
milestone: none → 22.04
Changed in charm-ceph-mon:
status: Fix Committed → Fix Released
Revision history for this message
Pedro Victor Lourenço Fragola (pedrovlf) wrote :

The pacific/stable charm version still with this issue, it is necessary to have the backport to commit[0] for pacific/stable charm.

juju run-action ceph-mon/leader --wait create-pool name=cinder-ceph3 pool-type=replicated profile-name=replicated_rule_ssd replicas=3
unit-ceph-mon-0:
  UnitId: ceph-mon/0
  id: "12"
  results:
    Stderr: |
      pool 'cinder-ceph3' created
      set pool 8 size to 3
      set pool 8 target_size_ratio to 0.1
      enabled application 'unknown' on pool 'cinder-ceph3'
  status: completed
  timing:
    completed: 2023-01-19 14:40:37 +0000 UTC
    enqueued: 2023-01-19 14:40:26 +0000 UTC

sudo ceph osd pool get cinder-ceph3 crush_rule
crush_rule: replicated_rule

[0] https://github.com/openstack/charm-ceph-mon/commit/da798bdd95f8fa19ce42363be6bfb268d62fe690

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-ceph-mon (stable/pacific)

Fix proposed to branch: stable/pacific
Review: https://review.opendev.org/c/openstack/charm-ceph-mon/+/898730

Revision history for this message
nikhil kshirsagar (nkshirsagar) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-ceph-mon (stable/pacific)

Reviewed: https://review.opendev.org/c/openstack/charm-ceph-mon/+/898730
Committed: https://opendev.org/openstack/charm-ceph-mon/commit/a70dd46214b82957c81fb37339e366393ef969a0
Submitter: "Zuul (22348)"
Branch: stable/pacific

commit a70dd46214b82957c81fb37339e366393ef969a0
Author: Aqsa Malik <email address hidden>
Date: Fri Feb 4 13:06:53 2022 +0100

    Add profile-name parameter in create-pool action

    This change adds a profile name parameter in the create-pool action that
    allows a replicated pool to be created with a CRUSH profile other than
    the default replicated_rule.

    Closes-Bug: #1905573

    Change-Id: Ib21ded8f4a977b4a2d57c6b6b4bb82721b12c4ea
    (cherry picked from commit da798bdd95f8fa19ce42363be6bfb268d62fe690)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.