cannot run pool-set action when attempting to apply and integer as a value

[Jeff Hillman]

Per the actions.yaml, when running the pool-set action, "Any valid Ceph key from http://docs.ceph.com/docs/master/rados/operations/pools/#set-pool-values" can be used.

However, when running

---

$ juju run-action ceph-mon/0 pool-set name=xfs-pool key=size value=3

---

I get the message "ERROR validation failed: (root).value : must be of type string, given 3"

I have tried putting the 3 in "'s and not change.

Per the above linked ceph doc, this particular value is an integer, not a string.

[Alex Kavanagh (ajkavanagh)]

Yup, this can't work looking at the code. The action says that value is a str, but not type conversion is done for ints fro the action type. i.e. the code should attempt to parse the string to the required value, as it can never actually be the value in the validator.

Relevant line: https://github.com/openstack/charm-ceph-mon/blob/86536fb52abf068d815209df790a28ec61025eb5/actions/pool_set.py#L30

This request will always have a str value for the value, but handle_set_pool_value() already expects "request" to be the correct type for the value.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/739048

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/739048
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-mon/commit/?id=b34d85ee81769a39e34d540699d4b5cf392736ae
Submitter: Zuul
Branch: master

commit b34d85ee81769a39e34d540699d4b5cf392736ae
Author: Alex Kavanagh <email address hidden>
Date: Thu Jul 2 14:56:41 2020 +0100

    Enable passing of integer value for pool-set action

    Enable passing of an integer to the pool-set function. Due to how juju
    appears to parse things on the command line, setting type to string
    causes it to fail to accept '3', "3" or 3 as a string. Only "'3'"
    works. However, if we remove the type from actions.yaml and do the
    validation in the charm, any value can be passed.

    Depends-On: I6081c23af61fd5e872982ff477b0a5cb27141d11

    Change-Id: Idf3468d9ae28dafc09c86f08b7f8c6470a665b7a
    Closes-Bug: #1838650