Support python3

[James Hebden]

When using python3, the charm encounters errors related to type mismatch.
subprocess requires an extra decode of return values to address this, ala:
https://git.launchpad.net/~jhebden/charm-ceilometer-agent/diff/hooks/charmhelpers/contrib/network/ip.py?h=onsite-fixes-17.02&id=5aa249f2af35a49c75ec09442d86a141c2811786

[Corey Bryant (corey.bryant)]

Hi James,

Thanks for the fix. Do we need the 2nd decode("utf-8")?

I ran a quick test on xenial: http://paste.ubuntu.com/24729399/

and one decode seemed to do the trick. I believe unicode for python2 is the same as str in python3.

Corey

[David Ames (thedac)]

Michael Skalka confirmed we do not need the second decode.

On Wed, May 31, 2017 at 12:34 PM, Corey Bryant
<email address hidden> wrote:
> Hi James,
>
> Thanks for the fix. Do we need the 2nd decode("utf-8")?
>
> I ran a quick test on xenial: http://paste.ubuntu.com/24729399/
>
> and one decode seemed to do the trick. I believe unicode for python2 is
> the same as str in python3.
>
> Corey
>
> ** Changed in: charm-ceilometer-agent
> Importance: Undecided => High
>
> ** Changed in: charm-ceilometer-agent
> Importance: High => Medium
>
> ** Changed in: charm-ceilometer-agent
> Status: New => Triaged
>
> --
> You received this bug notification because you are a member of OpenStack
> Charmers, which is subscribed to OpenStack Charms.
> Matching subscriptions: openstack-charms
> https://bugs.launchpad.net/bugs/1691881
>
> Title:
> Support python3
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/charm-ceilometer-agent/+bug/1691881/+subscriptions

[David Ames (thedac)]

https://code.launchpad.net/~thedac/charm-helpers/lp1691881/+merge/324891

[David Ames (thedac)]

https://review.openstack.org/469673

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/469673
Committed: https://git.openstack.org/cgit/openstack/charm-ceilometer-agent/commit/?id=36a4edff9cdd0f5fb07836e790030d49b39f562f
Submitter: Jenkins
Branch: master

commit 36a4edff9cdd0f5fb07836e790030d49b39f562f
Author: David Ames <email address hidden>
Date: Wed May 31 15:27:04 2017 -0700

    Decode subprocess output for python3 in ipv6 check

    When using python3, the code encounters errors related to type
    mismatch. subprocess requires an extra decode of return values
    to address this.

    CH Sync to get fix.

    Change-Id: I141c0d4d1851012d5c0a5a606402c75211a323f5
    Partial-Bug: #1691881