Charm should only write out files on change

[Haw Loeung]

Hi,

See logging that the following files are constantly being written out:

| 2019-03-17 21:37:40 INFO juju-log Reactive main running for hook update-status
| 2019-03-17 21:37:40 INFO juju-log Initializing Snap Layer
| 2019-03-17 21:37:40 INFO juju-log Invoking reactive handler: reactive/canonical_livepatch.py:187:init_nagios_checks
| 2019-03-17 21:37:40 INFO juju-log Writing file /etc/cron.d/check_canonical-livepatch root:root 644
| 2019-03-17 21:37:40 INFO juju-log Writing file /usr/lib/nagios/plugins/check_canonical-livepatch.py root:root 755
|
| 2019-03-17 21:43:23 INFO juju-log Reactive main running for hook update-status
| 2019-03-17 21:43:23 INFO juju-log Initializing Snap Layer
| 2019-03-17 21:43:23 INFO juju-log Invoking reactive handler: reactive/canonical_livepatch.py:187:init_nagios_checks
| 2019-03-17 21:43:23 INFO juju-log Writing file /etc/cron.d/check_canonical-livepatch root:root 644
| 2019-03-17 21:43:23 INFO juju-log Writing file /usr/lib/nagios/plugins/check_canonical-livepatch.py root:root 755
|
| 2019-03-17 21:48:58 INFO juju-log Reactive main running for hook update-status
| 2019-03-17 21:48:58 INFO juju-log Initializing Snap Layer
| 2019-03-17 21:48:58 INFO juju-log Invoking reactive handler: reactive/canonical_livepatch.py:187:init_nagios_checks
| 2019-03-17 21:48:58 INFO juju-log Writing file /etc/cron.d/check_canonical-livepatch root:root 644
| 2019-03-17 21:48:58 INFO juju-log Writing file /usr/lib/nagios/plugins/check_canonical-livepatch.py root:root 755

Causing unnecessary cron reloads:

| ar 17 21:38:01 hutton cron[2431]: (*system*check_canonical-livepatch) RELOAD (/etc/cron.d/check_canonical-livepatch)
| Mar 17 21:44:01 hutton cron[2431]: (*system*check_canonical-livepatch) RELOAD (/etc/cron.d/check_canonical-livepatch)
| Mar 17 21:49:01 hutton cron[2431]: (*system*check_canonical-livepatch) RELOAD (/etc/cron.d/check_canonical-livepatch)

[Haw Loeung (hloeung)]

FYI, this is with the latest charm.

.codetree_charmstore:
cs:canonical-livepatch-31;channel=stable

https://jujucharms.com/canonical-livepatch/:

Latest version (#31)

[Barry Price (barryprice)]

This is actually a regression, I'm certain we've fixed this before.

Will try to get a re;ease out this week to address thisone, along with some other recent bugfixes.

[Barry Price (barryprice)]

Okay, so in this case it was actually an old release on the unit:

-rw-r--r-- 1 root root 8387 Apr 24 2018 canonical_livepatch.py

Closing this as invalid, and working out why the latest wasn't deployed, even though .codetree_charmstore shows it was downloaded (which is still a problem, but not a charm bug).