livepatch charm should default to using juju model-config http_proxy and https_proxy if proxy vars not set
Bug #1769762 reported by
Drew Freiberger
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical Livepatch Charm |
Fix Released
|
Medium
|
Barry Price | ||
| Snap Layer |
New
|
Undecided
|
Unassigned | ||
Bug Description
As juju now has ability to manage model-wide http_proxy and https_proxy settings, Canonical-livepatch charm should defer to model configs before reverting to direct connectivity if the proxy URLs are not set. Requiring per-charm proxy configuration is prone to errors and is non-intuitive. Having the local charm configs for overrides for odd setups is good.
Related branches
~barryprice/charm-canonical-livepatch/+git/canonical-livepatch-charm:master
Merged
into
~livepatch-charmers/charm-canonical-livepatch:master
at
revision 74b40b32f58e96cf431425f07e6f166a53e281c0
- Paul Gear (community): Approve
-
Diff: 161 lines (+32/-85)1 file modifiedreactive/canonical_livepatch.py (+32/-85)
Revision history for this message
| Drew Freiberger (afreiberger) wrote | #1 |
Revision history for this message
| Barry Price (barryprice) wrote | #2 |
| Changed in canonical-livepatch-charm: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| assignee: | nobody → Barry Price (barryprice) |
| Changed in canonical-livepatch-charm: | |
| status: | Triaged → In Progress |
| Changed in canonical-livepatch-charm: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
Charm settings for reference are livepatch_proxy and snap_proxy. model configs land straight into all users' shell environment variables.
Debug log shows, potentially:
2018-05-06 17:28:14 DEBUG config-changed 2018/05/06 17:28:14 error executing enable: Couldn't send req: Post https:/