Groveller fails on ECL when libffi is used

[Elias Martenson]

Tested on Arch linux with ECL 15.3.7 and CFFI 0.15.0 (as shipped by Quicklisp)

The definition of pkg-config-cflags uses INVOKE to run "pkg-config libffi --cflags". On ECL, INVOKE always returns the fixed string "<see above>" (can be seen in the ECL definition of %INVOKE in invoke.lisp). This string is then passed to the grovel command line, resulting in an error.

The easiest way to reproduce this is to try to quickload the project "cl-rabbit" using ECL. The following output can be seen:

> (ql:quickload "cl-rabbit")
To load "cl-rabbit":
  Load 1 ASDF system:
    cl-rabbit
; Loading "cl-rabbit"
; pkg-config libffi --cflags
; cc -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -g -O2 -fPIC -D_THREAD_SAFE -Dlinux <see above> -I/home/emartenson/quicklisp/dists/quicklisp/software/cffi_0.15.0/ -o /home/emartenson/.cache/common-lisp/ecl-15.3.7-a4283c3f-linux-x64/home/emartenson/quicklisp/dists/quicklisp/software/cffi_0.15.0/libffi/libffi-unix /home/emartenson/.cache/common-lisp/ecl-15.3.7-a4283c3f-linux-x64/home/emartenson/quicklisp/dists/quicklisp/software/cffi_0.15.0/libffi/libffi-unix.c

Condition of type: GROVEL-ERROR
External process exited with code 1.
Command was: "cc" "-m64" " -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -g -O2 -fPIC -D_THREAD_SAFE -Dlinux" "<see above>" "-I/home/emartenson/quicklisp/dists/quicklisp/software/cffi_0.15.0/" "-o" "/home/emartenson/.cache/common-lisp/ecl-15.3.7-a4283c3f-linux-x64/home/emartenson/quicklisp/dists/quicklisp/software/cffi_0.15.0/libffi/libffi-unix" "/home/emartenson/.cache/common-lisp/ecl-15.3.7-a4283c3f-linux-x64/home/emartenson/quicklisp/dists/quicklisp/software/cffi_0.15.0/libffi/libffi-unix.c"
Output was:
<see above>
Available restarts:

1. (RETRY) Retry PROCESS-OP on #<grovel-file "cffi-libffi" "libffi" "libffi">.
2. (ACCEPT) Continue, treating PROCESS-OP on #<grovel-file "cffi-libffi" "libffi" "libffi"> as having been successful.
3. (RETRY) Retry ASDF operation.
4. (CLEAR-CONFIGURATION-AND-RETRY) Retry ASDF operation after resetting the configuration.
5. (ABORT) Give up on "cl-rabbit"
6. (RESTART-TOPLEVEL) Go back to Top-Level REPL.

Broken at SI:BYTECODES. [Evaluation of: (QUICKLISP-CLIENT:QUICKLOAD "cl-rabbit")] In: #<process TOP-LEVEL>.
>>

[Luís Oliveira (luismbo)]

Fix for ECL has been commited. CLISP suffers from the same issue.

[Luís Oliveira (luismbo)]

Fixed by Daniel in https://github.com/cffi/cffi/commit/6541d8f3b3eefb37d62b521006f8c108e79c9a11