notification agent sets up redundant consumers

Bug #1397424 reported by gordon chung
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Medium
gordon chung
Juno
Fix Released
Medium
gordon chung

Bug Description

when setting up listeners, the notification agent calls get_targets to retreive a list of queues to create a consumer for. unfortunately, we call get_targets per meter even though the exchange and queue itself is the same for related meters (ie. all the identity meters listen to keystone exchange, notification topic).

because of this we're creating a lot of duplicate consumers which from end user pov, makes no difference but if looking at stats ie. 'rabbitmqctl list_consumers.' there are a lot of extra consumers which don't really need to be there.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/137849

gordon chung (chungg)
description: updated
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/137849
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=ae99fa648495b69411f2e19333da211ca76bca23
Submitter: Jenkins
Branch: master

commit ae99fa648495b69411f2e19333da211ca76bca23
Author: gordon chung <email address hidden>
Date: Fri Nov 28 15:17:24 2014 -0500

    ensure unique list of consumers created

    this patch makes sure that we don't create duplicate consumers when
    setting up notification listener

    Change-Id: I3974fb8fcc78d57bbe41e2a234859d15ab8d9db0
    Closes-Bug: #1397424

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/153951

Thierry Carrez (ttx)
Changed in ceilometer:
milestone: kilo-1 → 2015.1.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (stable/juno)

Reviewed: https://review.openstack.org/153951
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=981754c4f67c7f5e7535e68138d5f36bebf1ae3e
Submitter: Jenkins
Branch: stable/juno

commit 981754c4f67c7f5e7535e68138d5f36bebf1ae3e
Author: gordon chung <email address hidden>
Date: Fri Nov 28 15:17:24 2014 -0500

    ensure unique list of consumers created

    this patch makes sure that we don't create duplicate consumers when
    setting up notification listener

    Change-Id: I3974fb8fcc78d57bbe41e2a234859d15ab8d9db0
    Closes-Bug: #1397424
    (cherry picked from commit ae99fa648495b69411f2e19333da211ca76bca23)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.