volume.snapshot.size broken due to user_id attributeerror

[Tobias Urdin]

Ceilometer is polling snapshots using cinderclient volume_snapshots.list() but for some reason it's not using the api_version >= 3.41 which makes sure user_id is included in the output data.

This causes an attributeerror
2018-09-26 11:21:45.696 26825 INFO ceilometer.polling.manager [-] Polling pollster volume.snapshot.size in the context of some_pollsters
2018-09-26 11:21:45.697 26825 ERROR ceilometer.polling.manager [-] Continue after error from volume.snapshot.size: user_id: AttributeError: user_id
2018-09-26 11:21:45.697 26825 ERROR ceilometer.polling.manager Traceback (most recent call last):
2018-09-26 11:21:45.697 26825 ERROR ceilometer.polling.manager File "/usr/lib/python2.7/site-packages/ceilometer/polling/manager.py", line 204, in poll_and_notify
2018-09-26 11:21:45.697 26825 ERROR ceilometer.polling.manager for sample in samples:
2018-09-26 11:21:45.697 26825 ERROR ceilometer.polling.manager File "/usr/lib/python2.7/site-packages/ceilometer/volume/cinder.py", line 85, in get_samples
2018-09-26 11:21:45.697 26825 ERROR ceilometer.polling.manager user_id=snapshot.user_id,
2018-09-26 11:21:45.697 26825 ERROR ceilometer.polling.manager File "/usr/lib/python2.7/site-packages/cinderclient/apiclient/base.py", line 510, in __getattr__
2018-09-26 11:21:45.697 26825 ERROR ceilometer.polling.manager raise AttributeError(k)
2018-09-26 11:21:45.697 26825 ERROR ceilometer.polling.manager AttributeError: user_id

It must use atleast 3.41 here [1] or we need to check before accessing the value here [2]

[1] https://github.com/openstack/ceilometer/blob/stable/rocky/ceilometer/volume/discovery.py#L32
[2] https://github.com/openstack/ceilometer/blob/stable/rocky/ceilometer/volume/cinder.py#L85

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/605459

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/605459
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=be524d2b74ad61fd208a505980af00fefe37022c
Submitter: Zuul
Branch: master

commit be524d2b74ad61fd208a505980af00fefe37022c
Author: Tobias Urdin <email address hidden>
Date: Wed Sep 26 17:25:01 2018 +0200

    Volume discovery minimum 3.43 api version

    Set the volume api version to 3.43 to make
    sure we get 3.41 change where it exposes
    the user_id for snapshots.

    This will fix the volume.snapshot.size metric
    that is not working when trying to access the
    user_id throws a AttributeError.

    Change-Id: I2414717e7c9e64b0092fe93c97a062a48dbf09a8
    Closes-Bug: 1794475

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/609444

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/609444
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=6ed05135a8b25c811f980950d88635e68bfbf179
Submitter: Zuul
Branch: stable/rocky

commit 6ed05135a8b25c811f980950d88635e68bfbf179
Author: Tobias Urdin <email address hidden>
Date: Wed Sep 26 17:25:01 2018 +0200

    Volume discovery minimum 3.43 api version

    Set the volume api version to 3.43 to make
    sure we get 3.41 change where it exposes
    the user_id for snapshots.

    This will fix the volume.snapshot.size metric
    that is not working when trying to access the
    user_id throws a AttributeError.

    Change-Id: I2414717e7c9e64b0092fe93c97a062a48dbf09a8
    Closes-Bug: 1794475
    (cherry picked from commit be524d2b74ad61fd208a505980af00fefe37022c)

[Tobias Urdin (tobias-urdin)]

This will be released in 11.0.1 release https://review.openstack.org/#/c/609650/

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ceilometer 11.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ceilometer 12.0.0.0rc1 release candidate.