Unit test failed at test_discovery_with_libvirt_error

[Hang Yang]

I'm using stable/queens ceilometer with libvirt-python==3.10.0. I added the libvirt-python into requirements.txt before running tox command and got the following error:

22:03:48 ==============================
22:03:48 Failed 1 tests - output below:
22:03:48 ==============================
22:03:48
22:03:48 ceilometer.tests.unit.compute.test_discovery.TestDiscovery.test_discovery_with_libvirt_error
22:03:48 --------------------------------------------------------------------------------------------
22:03:48
22:03:48 Captured traceback:
22:03:48 ~~~~~~~~~~~~~~~~~~~
22:03:48 Traceback (most recent call last):
22:03:48 File "/tmp/ceilometer/ceilometer/.tox/py27/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched
22:03:48 return func(*args, **keywargs)
22:03:48 File "ceilometer/tests/unit/compute/test_discovery.py", line 298, in test_discovery_with_libvirt_error
22:03:48 resources = dsc.discover(mock.MagicMock())
22:03:48 File "ceilometer/compute/discovery.py", line 120, in discover
22:03:48 return self.discover_libvirt_polling(manager, param=None)
22:03:48 File "/tmp/ceilometer/ceilometer/.tox/py27/lib/python2.7/site-packages/tenacity/__init__.py", line 214, in wrapped_f
22:03:48 return self.call(f, *args, **kw)
22:03:48 File "/tmp/ceilometer/ceilometer/.tox/py27/lib/python2.7/site-packages/tenacity/__init__.py", line 295, in call
22:03:48 start_time=start_time)
22:03:48 File "/tmp/ceilometer/ceilometer/.tox/py27/lib/python2.7/site-packages/tenacity/__init__.py", line 244, in iter
22:03:48 retry = self.retry(fut)
22:03:48 File "/tmp/ceilometer/ceilometer/.tox/py27/lib/python2.7/site-packages/tenacity/retry.py", line 65, in __call__
22:03:48 return self.predicate(attempt.exception())
22:03:48 File "ceilometer/compute/virt/libvirt/utils.py", line 102, in is_disconnection_exception
22:03:48 return (isinstance(e, libvirt.libvirtError)
22:03:48 TypeError: isinstance() arg 2 must be a class, type, or tuple of classes and types

test_discovery_with_libvirt_error is normally skipped as requirements/test-requirements do not include the libvirt-python. @testtools.skipUnless(libvirt, "libvirt not available") But in my case I'm building an internal rpm thus need libvirt-python in requirement.txt and I expect this test case should pass.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ceilometer 18.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ceilometer 17.0.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ceilometer train-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ceilometer ussuri-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ceilometer victoria-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ceilometer wallaby-eom release.