ceilometer-ipmi logs incorrect message when polling voltage

[the-bling]

Versions used:
ceilometer-ipmi 6.1.3
ipmitool 1.8.15

On my machine, ipmitool sdr -v type Voltage does not return any output.

But when ceilometer ipmi-agent executes the command while polling, it logs "Polling pollster hardware.ipmi.voltage in the context of meter_source" which is incorrect, instead of "failing to poll..." or similar error message. No samples for voltage are stored for this.

Snippet of log follows...
2017-02-22 07:15:48.059 18110 INFO ceilometer.agent.manager [req-bab9d880-51f3-44ff-bce5-5b101f4995bc admin - - - -] Polling pollster hardware.ipmi.voltage in the context of meter_source
2017-02-22 07:15:48.060 18110 DEBUG oslo_concurrency.processutils [req-bab9d880-51f3-44ff-bce5-5b101f4995bc admin - - - -] Running cmd (subprocess): sudo ceilometer-rootwrap /etc/ceilometer/rootwrap.conf ipmitool sdr -v type Voltage execute /usr/lib/python2.7/site-packages/oslo_concurrency/processutils.py:344
2017-02-22 07:15:48.677 18110 DEBUG oslo_concurrency.processutils [req-bab9d880-51f3-44ff-bce5-5b101f4995bc admin - - - -] CMD "sudo ceilometer-rootwrap /etc/ceilometer/rootwrap.conf ipmitool sdr -v type Voltage" returned: 0 in 0.617s execute /usr/lib/python2.7/site-packages/oslo_concurrency/processutils.py:374
2017-02-22 07:15:48.679 18110 INFO ceilometer.agent.manager [req-bab9d880-51f3-44ff-bce5-5b101f4995bc admin - - - -] Polling pollster hardware.ipmi.temperature in the context of meter_source
2017-02-22 07:15:48.680 18110 DEBUG oslo_concurrency.processutils [req-bab9d880-51f3-44ff-bce5-5b101f4995bc admin - - - -] Running cmd (subprocess): sudo ceilometer-rootwrap /etc/ceilometer/rootwrap.conf ipmitool sdr -v type Temperature execute /usr/lib/python2.7/site-packages/oslo_concurrency/processutils.py:344
2017-02-22 07:15:49.467 18110 DEBUG oslo_concurrency.processutils [req-bab9d880-51f3-44ff-bce5-5b101f4995bc admin - - - -] CMD "sudo ceilometer-rootwrap /etc/ceilometer/rootwrap.conf ipmitool sdr -v type Temperature" returned: 0 in 0.788s execute /usr/lib/python2.7/site-packages/oslo_concurrency/processutils.py:374
2017-02-22 07:15:49.481 18110 DEBUG oslo_messaging._drivers.amqpdriver [req-bab9d880-51f3-44ff-bce5-5b101f4995bc admin - - - -] CAST unique_id: d27fe25a6afd43809842fd93c11dfc4b NOTIFY exchange 'ceilometer' topic 'notifications.sample' _send /usr/lib/python2.7/site-packages/oslo_messaging/_drivers/amqpdriver.py:438

[gordon chung (chungg)]

i'm slightly torn regarding this. i imagine the polling is returning None which is why you don't see anything stored but the polling message still appears. i don't think this is necessarily a bug as it's not failing to poll, just that ipmi doesn't have the data when asked/polled?

[gordon chung (chungg)]

i'm going to mark this as won't fix as there isn't any activity and to be honest, i think it's more correct to log it as "polled but no result" versus "error and no result"