Fix "Message object do not support addition".

Bug #1652414 reported by Zhenyu Zheng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
High
Liusheng
OpenStack Heat
Fix Released
Medium
huangtianhua
python-novaclient
Fix Released
High
Zhenyu Zheng

Bug Description

In the 7.0.0 Novaclient release we added some warning log about using "endpoint_type"
rather than "interface" when init novaclient:
https://github.com/openstack/python-novaclient/blob/master/novaclient/client.py#L312-L327
https://github.com/openstack/python-novaclient/blob/master/novaclient/client.py#L249-L272

This is now causing alot jenkins failures acroos projects that is using novaclient with
enable_lazy set to False. As in this kind of scenario the warning message is a message
object instead of unicode sting and it cannot be added:
http://git.openstack.org/cgit/openstack/oslo.i18n/tree/oslo_i18n/_message.py#n227
and "Message object do not support addition" will raise.

Related Jenkins Error:
Ceilometer:
http://logs.openstack.org/29/333129/3/check/gate-ceilometer-python27-ubuntu-xenial/bd125e7/

---------------------------------------
For ceilometer, it also has "AttributeError: 'module' object has no attribute 'HTTPClient'"[1] error because novaclient 7.0.0 release.

[1] http://logs.openstack.org/72/414072/5/check/gate-ceilometer-python27-ubuntu-xenial/8806ac6/testr_results.html.gz

Changed in python-novaclient:
assignee: nobody → Zhenyu Zheng (zhengzhenyu)
description: updated
Changed in python-novaclient:
importance: Undecided → High
description: updated
Changed in python-novaclient:
status: New → In Progress
Revision history for this message
huangtianhua (huangtianhua) wrote :
Changed in heat:
assignee: nobody → huangtianhua (huangtianhua)
status: New → In Progress
importance: Undecided → Medium
Liusheng (liusheng)
Changed in ceilometer:
assignee: nobody → Liusheng (liusheng)
description: updated
Changed in ceilometer:
importance: Undecided → High
Changed in ceilometer:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/414072
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=c0e42f00af9ed8d8b3e81de2e67a6e5e7bbcecdf
Submitter: Jenkins
Branch: master

commit c0e42f00af9ed8d8b3e81de2e67a6e5e7bbcecdf
Author: Julien Danjou <email address hidden>
Date: Thu Dec 22 13:06:48 2016 +0100

    Fix the gate failure because of several issues

    1. Fix expecting content-type headers in gabbit tests, the headers don't
    contain the charset anymore, just remove it.

    2. Use 'endpoint_type' instead of 'interface' while init novaclient,
    because novaclient has deprecated the name 'interface', see[1].

    3. Don't use novaclient.HTTPClient, since the 'HTTPCLient' has been
    deprecated in novaclient, see[2].

    [1] https://review.openstack.org/#/c/406299/
    [2] https://review.openstack.org/#/c/408728/

    Closes-Bug: #1652414
    Change-Id: I33f2dd9303b93391ff40d77cf93e6e285c983287
    Co-Authored-By: Hanxi Liu <email address hidden>
    Co-Authored-By: liusheng <email address hidden>

Changed in ceilometer:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (stable/mitaka)

Reviewed: https://review.openstack.org/415165
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=dea42810ef9f29c5ede0076bfd4d2788235bcbd3
Submitter: Jenkins
Branch: stable/mitaka

commit dea42810ef9f29c5ede0076bfd4d2788235bcbd3
Author: Hanxi Liu <email address hidden>
Date: Tue Dec 27 17:09:11 2016 +0800

    Fix the gate failure because of several issues

    1. Fix expecting content-type headers in gabbit tests, the headers don't
    contain the charset anymore, just remove it.

    2. Use 'endpoint_type' instead of 'interface' while init novaclient,
    because novaclient has deprecated the name 'interface', see[1].

    3. Don't use novaclient.HTTPClient, since the 'HTTPCLient' has been
    deprecated in novaclient, see[2].

    [1] https://review.openstack.org/#/c/406299/
    [2] https://review.openstack.org/#/c/408728/

    Closes-Bug: #1652414
    Change-Id: I07790b2a270fd4dc4ca95e95b01fbd41b4c43cf3
    (cherry picked from commit 23acafbd9ddaff65b927fc2cbad33b9ed3f118b0)
    Co-Authored-By: Julien Danjou <email address hidden>
    Co-Authored-By: liusheng <email address hidden>

tags: added: in-stable-mitaka
Changed in python-novaclient:
assignee: Zhenyu Zheng (zhengzhenyu) → Matt Riedemann (mriedem)
Changed in python-novaclient:
assignee: Matt Riedemann (mriedem) → Zhenyu Zheng (zhengzhenyu)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/414529
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=aeec4d11b2dae769bfe020dcd95ec607afaeed55
Submitter: Jenkins
Branch: master

commit aeec4d11b2dae769bfe020dcd95ec607afaeed55
Author: Kevin_Zheng <email address hidden>
Date: Fri Dec 23 17:38:57 2016 +0800

    Fix "Message object do not support addition".

    In the 7.0.0 Novaclient release we added some warning
    log about user should using "endpoint_type" rather than
    "interface" when init novaclient:
    https://github.com/openstack/python-novaclient/blob/master/novaclient/client.py#L312-L327

    https://github.com/openstack/python-novaclient/blob/master/novaclient/client.py#L249-L272

    This is now causing a lot jenkins failures acroos projects
    that is using novaclient with enable_lazy set to False.
    As in this kind of scenario the warning message is a message
    object instead of unicode sting and it cannot be added:
    http://git.openstack.org/cgit/openstack/oslo.i18n/tree/oslo_i18n/_message.py#n227

    and "Message object do not support addition" will raise.

    Related Jenkins Error:
    Ceilometer:
    http://logs.openstack.org/29/333129/3/check/gate-ceilometer-python27-ubuntu-xenial/bd125e7/

    Closes-bug: #1652414
    Change-Id: I11a490f759fdac9707c1321c9659da2605196a94

Changed in python-novaclient:
status: In Progress → Fix Released
Changed in heat:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-novaclient 7.1.0

This issue was fixed in the openstack/python-novaclient 7.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ceilometer 6.1.4

This issue was fixed in the openstack/ceilometer 6.1.4 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ceilometer 8.0.0

This issue was fixed in the openstack/ceilometer 8.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.