Socket type resolution fails on ipv6 hostnames

Bug #1616496 reported by Amy Fong
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Undecided
Amy Fong

Bug Description

UDPPublisher tries to determine the IP version by attempting to do a netutils.is_valid_ipv6 test on the host part. In cases where the host is a hostname (as opposed to an IP addr), and in cases where this is an IPv6 address, netutils.is_valid_ipv6 fails and the constructor incorrectly determines that the address family is IPv4.

Revision history for this message
Amy Fong (afong2) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/359964

Changed in ceilometer:
assignee: nobody → Amy Fong (afong2)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ceilometer (master)

Change abandoned by Amy Fong (<email address hidden>) on branch: master
Review: https://review.openstack.org/359964
Reason: (hit publish by mistake)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/359964
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=e41adba727b97bcc5c32d23b4a0cb9a1292bef5e
Submitter: Jenkins
Branch: master

commit e41adba727b97bcc5c32d23b4a0cb9a1292bef5e
Author: Amy Fong <email address hidden>
Date: Wed Aug 24 11:24:38 2016 -0400

    Fix checking IP version when using IPv6.

    This commit fixes an issue with ceilometer incorrectly determining the
    IP version to use. Previously, it checked whether the hostname was a
    valid IPv6 address, but it should be resolving first to check whether
    that is a valid IP address instead.

    tests: Created test case that enables creating a UDPPublisher with
    hostname for ipv4 and ipv6.

    Closes-bug: #1616496

    Change-Id: I586104fe69a03e64a0fb7572442b3175f880d80d
    Co-authored-by: Joseph Richard <email address hidden>

Changed in ceilometer:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ceilometer 7.0.0.0b3

This issue was fixed in the openstack/ceilometer 7.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.