Stopping collector service creates Error messages in logs

[Igor Degtiarov]

After collector service is stopped we got in logs a lot of error messages:

ERROR ceilometer Traceback (most recent call last):
2016-04-22 09:33:13.153 8484 ERROR ceilometer File "/usr/bin/ceilometer-collector", line 10, in <module>
2016-04-22 09:33:13.153 8484 ERROR ceilometer sys.exit(main())
2016-04-22 09:33:13.153 8484 ERROR ceilometer File "/usr/lib/python2.7/dist-packages/ceilometer/cmd/eventlet/collector.py", line 29, in main
2016-04-22 09:33:13.153 8484 ERROR ceilometer workers=CONF.collector.workers).wait()
2016-04-22 09:33:13.153 8484 ERROR ceilometer File "/usr/lib/python2.7/dist-packages/oslo_service/service.py", line 534, in wait
2016-04-22 09:33:13.153 8484 ERROR ceilometer self.stop()
2016-04-22 09:33:13.153 8484 ERROR ceilometer File "/usr/lib/python2.7/dist-packages/oslo_service/service.py", line 543, in stop
2016-04-22 09:33:13.153 8484 ERROR ceilometer service.stop()
2016-04-22 09:33:13.153 8484 ERROR ceilometer File "/usr/lib/python2.7/dist-packages/ceilometer/collector.py", line 148, in stop
2016-04-22 09:33:13.153 8484 ERROR ceilometer if self.sample_listener:
2016-04-22 09:33:13.153 8484 ERROR ceilometer AttributeError: 'CollectorService' object has no attribute 'sample_listener'

It happens because we trying to close listeners that is already closed by parent process.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/317366

[OpenStack Infra (hudson-openstack)]

Change abandoned by Igor Degtiarov (<email address hidden>) on branch: master
Review: https://review.openstack.org/317366
Reason: This bug is fixed with the patch https://review.openstack.org/#/c/309331/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/309331
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=1ab0acb851a72e4a13903dab73a20a45de98baaa
Submitter: Jenkins
Branch: master

commit 1ab0acb851a72e4a13903dab73a20a45de98baaa
Author: Mehdi Abaakouk <email address hidden>
Date: Fri Apr 22 10:14:36 2016 +0200

    pollsters: Remove eventlet timers

    This change removes usage of eventlet timers.

    This allows coordinator heartbeat/watchers to work correctly
    when the main thread is stuck for any reason (IO, time.sleep, ...).

    This also fixes a concurrency issue in the notification-agent between
    stop/reload_pipeline/refresh_agent that manipulate listeners.

    For example a listener stopped by stop() could be restart by
    reload_pipeline or refresh_agent. Now we use the coord_lock to
    protect the listener manipulations and ensure we are not in a shutdown
    process when we restart it.

    This bug can't occurs with greenlet because we don't monkeypatch system
    call for a while now and all of this methods wasn't ran in concurrency
    manner. But remplacing greenlet by reel thread have show up the bug.

    Closes-Bug: #1582641
    Change-Id: I21c3b953a296316b983114435fcbeba1e29f051e

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/ceilometer 7.0.0.0b2 development milestone.