some test for mysql are wrongly skipped

Bug #1519211 reported by ZhiQiang Fan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Aodh
Fix Released
Low
ZhiQiang Fan
Ceilometer
Fix Released
Low
ZhiQiang Fan

Bug Description

found in http://logs.openstack.org/07/240107/9/check/gate-ceilometer-dsvm-functional-mysql/1b6efd8/testr_results.html.gz

for example:

tox -epy-mysql -- ceilometer.tests.functional.api.v2.test_event_scenarios.AclRestrictedEventTestBase.test_admin_access_trait_filter_no_access

ceilometer.tests.functional.api.v2.test_event_scenarios.AclRestrictedEventTestBase.test_admin_access_trait_filter_no_access(mysql) ... SKIPPED: Test is not applicable for mysql+pymysql

related bug: https://bugs.launchpad.net/ceilometer/+bug/1506777 , this bug fix only enables mysql test, but doesn't take good care for all test cases

ZhiQiang Fan (aji-zqfan)
Changed in aodh:
assignee: nobody → ZhiQiang Fan (aji-zqfan)
Changed in ceilometer:
assignee: nobody → ZhiQiang Fan (aji-zqfan)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/249019

Changed in ceilometer:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to aodh (master)

Fix proposed to branch: master
Review: https://review.openstack.org/249063

Changed in aodh:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/249019
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=3549f782d11a1af1c32d8f9ebf86dcce1e81ac2b
Submitter: Jenkins
Branch: master

commit 3549f782d11a1af1c32d8f9ebf86dcce1e81ac2b
Author: ZhiQiang Fan <email address hidden>
Date: Tue Nov 24 21:46:37 2015 +0800

    fix some test case wrongly skipped for mysql backend

    https://review.openstack.org/#/c/235831/ enables all test cases for
    ysql when PyMySQL is used as MySQL driver, but some test cases are
    specified via run_with() decorator, which might expect engine is mysql
    while actually we provide mysql+pymysql, so these test cases will be
    wrongly skipped.

    This patch maps mysql+pymysql to mysql to make sure there is an engine
    handles it for such case.

    Change-Id: I062d1d04b4b1511626a9b02f0249b5c93b5592b8
    Closes-Bug: #1519211

Changed in ceilometer:
status: In Progress → Fix Committed
gordon chung (chungg)
Changed in aodh:
importance: Undecided → Medium
Changed in ceilometer:
importance: Undecided → Low
Changed in aodh:
importance: Medium → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to aodh (master)

Reviewed: https://review.openstack.org/249063
Committed: https://git.openstack.org/cgit/openstack/aodh/commit/?id=7dcf7d436847e98a741057c7e46bfbe114492104
Submitter: Jenkins
Branch: master

commit 7dcf7d436847e98a741057c7e46bfbe114492104
Author: ZhiQiang Fan <email address hidden>
Date: Wed Nov 25 00:18:27 2015 +0800

    fix some test cases wrongly skipped for mysql backend

    There are 10 test cases which is skipped when we run mysql functional
    test, because they are decorated by run_with(), which expects to be
    handled by engine mysql, but gets engine mysql+pymysql.

    This patch maps engine mysql+pymysql to mysql to enable these tests.

    Change-Id: Ief0646b6ca66e514300cbc93d3e5e66b0573b590
    Closes-Bug: #1519211

Changed in aodh:
status: In Progress → Fix Committed
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/ceilometer 6.0.0.0b1

This issue was fixed in the openstack/ceilometer 6.0.0.0b1 development milestone.

Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/aodh 2.0.0.0b1

This issue was fixed in the openstack/aodh 2.0.0.0b1 development milestone.

Changed in aodh:
status: Fix Committed → Fix Released
Liusheng (liusheng)
Changed in ceilometer:
milestone: none → mitaka-1
Changed in aodh:
milestone: none → next-mitaka
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.