Unneccessary log message of neutronclient when polling neutron resources

Bug #1504396 reported by Liusheng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Low
Liusheng

Bug Description

As bug 1499403 reported, there are may warning of regular resource not found when polling neutron, but the patch cannot fix that issue. Because the fix tried to accept exceptions.NotFound and recording a warning message, but actually, the exception maybe exceptions.NeutronClientException, which is superclass of exceptions.NotFound.

Liusheng (liusheng)
Changed in ceilometer:
assignee: nobody → Liusheng (liusheng)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/232862

Changed in ceilometer:
status: New → In Progress
Revision history for this message
Rohit Jaiswal (rohit-jaiswal-3) wrote :

Neutron client should raise a NotFound exception when resource not found in neutron: https://github.com/openstack/python-neutronclient/blob/master/neutronclient/v2_0/client.py#L67

Revision history for this message
Liusheng (liusheng) wrote :

Hi Rohit, Yeah, I agree, but I guess for now, not all neutronclient API raise NotFound exception when resource not found, because I have update code with master in my environment, I can still find the 404 log message.

Revision history for this message
Rohit Jaiswal (rohit-jaiswal-3) wrote :

I think the neutron client 404 is because of neutron client log level in debug mode..

Revision history for this message
Liusheng (liusheng) wrote :

Rohit, not exactly, when I debug this issue, I found the 404 message is record by "LOG.warn(e)" statement, [1]

[1] https://github.com/openstack/ceilometer/blob/master/ceilometer/neutron_client.py#L47

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/232862
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=213b585ced83f101e3191318c4787ea4fdcc95ce
Submitter: Jenkins
Branch: master

commit 213b585ced83f101e3191318c4787ea4fdcc95ce
Author: liusheng <email address hidden>
Date: Fri Oct 9 12:40:50 2015 +0800

    Clean some log messages when polling neutron resources

    - Handle the regular resource not found warnings when polling neutron
      resources
    - Set the default log level of neutronclient to INFO to avoid recording
      requests of neutronclient token issuing.

    Change-Id: I94836b3031bae5bee2634b301c67a0c9487112ac
    Closes-Bug: #1504396

Changed in ceilometer:
status: In Progress → Fix Committed
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/ceilometer 6.0.0.0b1

This issue was fixed in the openstack/ceilometer 6.0.0.0b1 development milestone.

Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Liusheng (liusheng)
Changed in ceilometer:
importance: Undecided → Low
milestone: none → mitaka-1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.