Gnocchi

Gnocchi doesn't accept OpenStack id madness

Bug #1480346 reported by gordon chung
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Gnocchi
Fix Released
High
Chris Dent
Gnocchi 1.2.0

Bug Description

we have a lot of bs ids in OpenStack... gnocchi doesn't care for this bs so a lot of our meters will get tossed by gnocchi.

2015-07-31 10:57:36.641 31417 ERROR ceilometer.dispatcher.gnocchi [-] Resource nova-instance-instance-00000008-fa163e7cc5d0 creation failed with status: 400: <html>
 <head>
  <title>400 Bad Request</title>
 </head>
 <body>
  <h1>400 Bad Request</h1>
  The server could not comply with the request since it is either malformed or otherwise incorrect.<br /><br />
Invalid input: not a valid value for dictionary value @ data[u'id']

jiaxi (tjxiter)
Changed in ceilometer:
assignee: nobody → jiaxi (tjxiter)
Revision history for this message
Julien Danjou (jdanjou) wrote :

We're never going to fix that in Gnocchi AFAICT. Nova or the Ceilometer data retrieval needs to get fixed.

Changed in ceilometer:
status: New → Won't Fix
status: Won't Fix → Confirmed
summary: - gnocchi doesn't accept OpenStack id madness
+ Gnocchi doesn't accept OpenStack id madness
Revision history for this message
Chris Dent (cdent) wrote :

See https://review.openstack.org/216390 for a related proof of concept fix.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to ceilometer (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/216628

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/216628
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=33355eaf68c9fbd7731028f8a76438ea434d2919
Submitter: Jenkins
Branch: master

commit 33355eaf68c9fbd7731028f8a76438ea434d2919
Author: Mehdi Abaakouk <email address hidden>
Date: Tue Aug 25 11:00:13 2015 +0200

    gnocchi: quote the resource_id in url

    Some resource_id looks like "812c9916-83f7-460b-8b27-ab5a2ba98275/foobar".

    This change uses urllib.quote to encode them when they are used into
    a url.

    Related-bug: #1480346
    Change-Id: If19b0aec5f89e031b886b7f1e2233c0a88d1b4b1

Revision history for this message
Chris Dent (cdent) wrote :

I think we've effectively resolved this by merging https://review.openstack.org/216390

Will we need additional tooling to make it fully useful?

Revision history for this message
Julien Danjou (jdanjou) wrote :

I think we're good. Let's mark this as fixed.

Changed in ceilometer:
assignee: jiaxi (tjxiter) → Chris Dent (chdent)
status: Confirmed → Fix Committed
affects: ceilometer → gnocchi
Julien Danjou (jdanjou)
Changed in gnocchi:
milestone: none → 1.2.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.