DiskInfo pollster exception if there is no implementation for a certain metric

Bug #1460207 reported by Claudiu Belu
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Undecided
Octavian Ciuhandu
Kilo
Fix Released
Undecided
Unassigned

Bug Description

If a NotImplementedError exception is raised while getting samples through a DiskInfoPollster, another exception occurs, as it tries to access an attribute that does not exist.

The issue is caused by the line: https://github.com/openstack/ceilometer/blob/master/ceilometer/compute/pollsters/disk.py#L709

Logs: http://paste.openstack.org/show/245621/

Changed in ceilometer:
assignee: nobody → Octavian Ciuhandu (ociuhandu)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/186915

Changed in ceilometer:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/186915
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=b8b90ac0fd7fcf028cae5be24bd2551c116d80f8
Submitter: Jenkins
Branch: master

commit b8b90ac0fd7fcf028cae5be24bd2551c116d80f8
Author: Octavian Ciuhandu <email address hidden>
Date: Fri May 29 14:15:58 2015 -0700

    Fixes DiskInfoPollster AttributeError exception

    If a NotImplementedError exception is raised while getting samples through
    a DiskInfoPollster, another exception occurs, as it tries to access an
    attribute that does not exist.

    Replaces the usage of manager.inspector with self.inspector.

    Change-Id: Ie1bb6eaffc0b2671f8fefb4771dbd2191eb5cf5f
    Closes-Bug: #1460207

Changed in ceilometer:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/187956

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (stable/kilo)

Reviewed: https://review.openstack.org/187956
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=f200c54937f5bcd05bb3917128614a8d5c12f7ff
Submitter: Jenkins
Branch: stable/kilo

commit f200c54937f5bcd05bb3917128614a8d5c12f7ff
Author: Octavian Ciuhandu <email address hidden>
Date: Fri May 29 14:15:58 2015 -0700

    Fixes DiskInfoPollster AttributeError exception

    If a NotImplementedError exception is raised while getting samples through
    a DiskInfoPollster, another exception occurs, as it tries to access an
    attribute that does not exist.

    Replaces the usage of manager.inspector with self.inspector.

    Change-Id: Ie1bb6eaffc0b2671f8fefb4771dbd2191eb5cf5f
    Closes-Bug: #1460207
    (cherry picked from commit b8b90ac0fd7fcf028cae5be24bd2551c116d80f8)

tags: added: in-stable-kilo
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: liberty-1 → 5.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.