Notification handler unit tests do not test event types

[Rohit Jaiswal]

Unit tests for the notification handlers just test the part which emits the sample but not the event_types regex. The regex is instrumental in routing the notification to a plugin handler and should be unit tested.

Probably, use something similar to this -

def _get_match_status(self, event, notification_class):
        handler = notification_class(mock.Mock())
        event_filter = handler.filter_rule
        return event_filter.match(context=None,
                                  event_type=event,
                                  publisher_id=None,
                                  metadata=None,
                                  payload=None)

 def test_role_events(self):
       self.assertEqual(True, self._get_match_status('identity.role.created',
                                                      notifications.Role))
      self.assertEqual(False, self._get_match_status(
            'identity.role_assignment.created',
            notifications.Role))

[Rohit Jaiswal (rohit-jaiswal-3)]

Probably need to add something similar to above for all applicable notification handlers.

[Rohit Jaiswal (rohit-jaiswal-3)]

For instance, the bug https://bugs.launchpad.net/ceilometer/+bug/1457785 wouldn't exist if we had unit tests for supported event types for a noti. handler

[gordon chung (chungg)]

you might want to check with Prad. this test becomes moot when he does declarative metering work.

[Pradeep Kilambi (pkilambi)]

Agreed. With declarative notifications approach these tests might not be relevant in future.

[gordon chung (chungg)]

we have a few tests against event_types in declarative notification here: https://github.com/openstack/ceilometer/blob/master/ceilometer/tests/unit/meter/test_notifications.py

and also indirectly tested here:
https://github.com/openstack/ceilometer/blob/master/ceilometer/tests/functional/test_notification.py