tests wrongly assume trait ordering

Bug #1423714 reported by gordon chung
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Medium
gordon chung

Bug Description

the tests check that traits are returned in specific order but this is a false assumption.

======================================================================
FAIL: ceilometer.tests.api.v2.test_event_scenarios.TestEventAPI.test_get_event_by_message_id(mysql)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "ceilometer/tests/base.py", line 97, in skip_if_not_implemented
    return func(*args, **kwargs)
  File "ceilometer/tests/api/v2/test_event_scenarios.py", line 166, in test_get_event_by_message_id
    self.assertEqual(expected_traits, event['traits'])
  File "/opt/stack/ceilometer/.tox/debug-mysql/lib/python2.7/site-packages/testtools/testcase.py", line 348, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/opt/stack/ceilometer/.tox/debug-mysql/lib/python2.7/site-packages/testtools/testcase.py", line 433, in assertThat
    raise mismatch_error
MismatchError: !=:
reference = [{'name': 'trait_A', 'type': 'string', 'value': 'my_Bar_text'},
 {'name': 'trait_B', 'type': 'integer', 'value': '101'},
 {'name': 'trait_C', 'type': 'float', 'value': '100.123456'},
 {'name': 'trait_D', 'type': 'datetime', 'value': '2014-01-01T05:00:00'}]
actual = [{u'name': u'trait_D', u'type': u'datetime', u'value': u'2014-01-01T05:00:00'},
 {u'name': u'trait_B', u'type': u'integer', u'value': u'101'},
 {u'name': u'trait_C', u'type': u'float', u'value': u'100.123456'},
 {u'name': u'trait_A', u'type': u'string', u'value': u'my_Bar_text'}]

gordon chung (chungg)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/157615

Changed in ceilometer:
assignee: nobody → gordon chung (chungg)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/157615
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=4c4734c4481aeaa3d7449c0693197dae9ef33df3
Submitter: Jenkins
Branch: master

commit 4c4734c4481aeaa3d7449c0693197dae9ef33df3
Author: gordon chung <email address hidden>
Date: Thu Feb 19 19:21:32 2015 -0500

    order traits returned within events

    - we order the traits by key in all the backends except sql. this
    keeps sql inline.
    - this reverts a patch to sort traits post query in test.

    Change-Id: I17009bdb01106dc07659a9198da2090ec63bcf51
    Closes-Bug: #1423714

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.