IPMI unit test doesn't cover all platform initilization

Bug #1414903 reported by Zhai, Edwin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Medium
Zhai, Edwin

Bug Description

IPMI/NM unit test was designed to cover initialization on different platforms: IPMI/Non-IPMI, NM/Non-NM. As execution engine is singleton, test for the 2nd platform still use the 1st platform's engine and its initialization doesn't run at all. So only initialization code for one platform are tested.

Zhai, Edwin (edwin-zhai)
Changed in ceilometer:
assignee: nobody → Zhai, Edwin (edwin-zhai)
status: New → In Progress
Lianhao Lu (lianhao-lu)
Changed in ceilometer:
importance: Undecided → Medium
milestone: none → kilo-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/150290
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=4b37a36fbff3ad7a93b4afb9038f793548a6ef04
Submitter: Jenkins
Branch: master

commit 4b37a36fbff3ad7a93b4afb9038f793548a6ef04
Author: Edwin Zhai <email address hidden>
Date: Tue Jan 27 14:20:36 2015 +0800

    Fix IPMI unit test to cover different platforms

    As execution engine is singleton, test for the 2nd platform still use
    the 1st platform's engine and its initialization doesn't run at all.
    Reset engine init flag after test for each platform to fix it.

    Change-Id: I73b69892b8ee429ed649741419554076379c093c
    Closes-Bug: #1414903

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.