swift pollster doesn't import service_credentials

Bug #1373753 reported by Hisashi Osanai
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Medium
Hisashi Osanai

Bug Description

[Description]
swift pollster doesn't import service_credentials.
cfg.CONF.service_credentials is used L72 in swift.py but there is no import_group
method calling here.

     67 def _get_endpoint(ksclient):
     68 # we store the endpoint as a base class attribute, so keystone is
     69 # only ever called once
     70 if _Base._ENDPOINT is None:
     71 try:
     72 conf = cfg.CONF.service_credentials
     73 _Base._ENDPOINT = ksclient.service_catalog.url_for(
     74 service_type=cfg.CONF.service_types.swift,
     75 endpoint_type=conf.os_endpoint_type)
     76 except exceptions.EndpointNotFound:
     77 LOG.debug(_("Swift endpoint not found"))
     78 return _Base._ENDPOINT

[Version details]
-
[Crystal clear details to reproduce the bug]
-
[Test environment details]
-
[Actual results]
-
[Expected results]
-

I would like to have this bug if possible.

Dina Belova (dbelova)
Changed in ceilometer:
status: New → Confirmed
Changed in ceilometer:
assignee: nobody → Hisashi Osanai (osanai-hisashi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/124318

Changed in ceilometer:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/124318
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=157044dfcced0f971216ff371f1a3b4b12adae47
Submitter: Jenkins
Branch: master

commit 157044dfcced0f971216ff371f1a3b4b12adae47
Author: Hisashi Osanai <email address hidden>
Date: Tue Sep 30 15:39:18 2014 +0900

    Add cfg.CONF.import_group for service_credentials

    The cfg.CONF.service_credentials attribute is used without calling
    cfg.CONF.import_group. Add calling the method in this patch.

    Change-Id: I700c5ea7ae5ff3f61c28a767e5aa60db0dfb46ce
    Closes-Bug: 1373753

Changed in ceilometer:
status: In Progress → Fix Committed
Eoghan Glynn (eglynn)
Changed in ceilometer:
importance: Undecided → Medium
Eoghan Glynn (eglynn)
Changed in ceilometer:
milestone: none → kilo-1
Eoghan Glynn (eglynn)
tags: added: juno-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/138321

Alan Pevec (apevec)
tags: removed: juno-backport-potential
Eoghan Glynn (eglynn)
no longer affects: ceilometer/juno
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ceilometer (stable/juno)

Change abandoned by Eoghan Glynn (<email address hidden>) on branch: stable/juno
Review: https://review.openstack.org/138321
Reason: The import_group is really just belt'n'braces ... i.e. check that the group is registered ... not a user visible error really, so perhaps does not belong on stable.

Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.