Skipping test on NotImplementedError is unsafe

Bug #1369556 reported by Julien Danjou
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Medium
Julien Danjou

Bug Description

Skipping test when NotImplementedError is raised is dangerous as any Python module used in a storage driver could raise it. If that's the case, the test will be skipped rather than marked as failing.

Julien Danjou (jdanjou)
Changed in ceilometer:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Julien Danjou (jdanjou)
milestone: none → juno-rc1
Changed in ceilometer:
status: Confirmed → In Progress
Revision history for this message
Lianhao Lu (lianhao-lu) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/121518
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=62008d4e5bf688024c0be575ee37df20b82bb722
Submitter: Jenkins
Branch: master

commit 62008d4e5bf688024c0be575ee37df20b82bb722
Author: Julien Danjou <email address hidden>
Date: Mon Sep 15 12:07:04 2014 +0200

    Switch to a custom NotImplementedError

    Some drivers/modules might raise NotImplementedError whereas we would
    expect things to work. Skipping test when such an error is raised would
    be a bad idea, we would know the test failed.
    So let's switch to a custom NotImplementedError and let's skip test only
    if this one is raised.

    Closes-Bug: #1369556

    Change-Id: Ie88a281787218f9aba13b6e662eb4d49d3e685d0

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.