jenkins broken: test_keystone_middleware.* failed

[ZhiQiang Fan]

test_keystone_middleware_parse_conffile
 fail
test_keystone_middleware_conf
 fail
test_keystone_middleware_parse_conffile
 fail
test_keystone_middleware_conf

sample full log
http://logs.openstack.org/21/88221/1/check/gate-ceilometer-python27/4bce152/
http://logs.openstack.org/10/87110/1/check/gate-ceilometer-python27/89cc34f/
http://logs.openstack.org/69/87869/3/check/gate-ceilometer-python27/fbde553/

[ZhiQiang Fan (aji-zqfan)]

local pip freeze
python-keystoneclient==0.7.1
while jenkins
python-keystoneclient==0.8.0

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/88374

[ZhiQiang Fan (aji-zqfan)]

https://github.com/openstack/python-keystoneclient/blob/0.8.0/keystoneclient/middleware/auth_token.py#L455

self.auth_uri = urllib.parse.urljoin(self.identity_uri, '/')

self.LOG.warning(urllib.parse.urljoin('foo://x', '/')) shows: '/'
self.LOG.warning(urllib.parse.urljoin('http://x', '/')) shows: 'http://x/'

it seems six.move.urllib.parse.urljoin only accepts valid schema for now

so the test in api.v{1,2}.test_app override auth_protocol to barttp in conf file will no longer act like expect

[ZhiQiang Fan (aji-zqfan)]

and in keystoneclient==0.7.1

https://github.com/openstack/python-keystoneclient/blob/0.7.1/keystoneclient/middleware/auth_token.py#L419

    self.request_uri = '%s://%s:%s' % (auth_protocol, auth_host, auth_port)
    ...
    self.auth_uri = self.request_uri

there is no check for schema

[ZhiQiang Fan (aji-zqfan)]

read this discussion http://bugs.python.org/issue18828

From urllib.parse:

    uses_relative = ['ftp', 'http', 'gopher', 'nntp', 'imap',
                     'wais', 'file', 'https', 'shttp', 'mms',
                     'prospero', 'rtsp', 'rtspu', '', 'sftp',
                     'svn', 'svn+ssh']

too append the barttp as an valid schema, we should append it to parse.uses_relative, since keystone is out of the scope and it is no reason to hack source code for test code which just add an uncommon schema, I think we should modify our test code

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/88386

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/88374
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=e5b7606eaa94033256eb1aca5f6a6eed4f9e54a0
Submitter: Jenkins
Branch: master

commit e5b7606eaa94033256eb1aca5f6a6eed4f9e54a0
Author: Thomas Herve <email address hidden>
Date: Thu Apr 17 19:45:19 2014 +0200

    Use known protocol scheme in keystone tests

    With the recent introduction of the identity_uri in keystoneclient,
    there is a small backward incompatible change which means that weird
    protocols like the ones we use during tests aren't support properly
    anymore. The patch replaces "foottp" and "barttp" by "file" hopefully
    keeping testing coverage the same.

    Change-Id: Idb30ff3ee0ca50911e453899ad32e630f9b18724
    Closes-Bug: #1309092

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/88577

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/88577
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=a1ec218d683e27434a5b085f1fbc7e3c13b60684
Submitter: Jenkins
Branch: stable/icehouse

commit a1ec218d683e27434a5b085f1fbc7e3c13b60684
Author: Thomas Herve <email address hidden>
Date: Thu Apr 17 19:45:19 2014 +0200

    Use known protocol scheme in keystone tests

    With the recent introduction of the identity_uri in keystoneclient,
    there is a small backward incompatible change which means that weird
    protocols like the ones we use during tests aren't support properly
    anymore. The patch replaces "foottp" and "barttp" by "file" hopefully
    keeping testing coverage the same.

    Change-Id: Idb30ff3ee0ca50911e453899ad32e630f9b18724
    Closes-Bug: #1309092
    (cherry picked from commit e5b7606eaa94033256eb1aca5f6a6eed4f9e54a0)

[ZhiQiang Fan (aji-zqfan)]

Hi, Eoghan Glynn

can you backport to **havana** as soon as possible? I have patches blocked by this bug

thanks

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/88780

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/88780
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=5fc3f27b06b69b630c5e39d67c71a7a13aca2e79
Submitter: Jenkins
Branch: stable/havana

commit 5fc3f27b06b69b630c5e39d67c71a7a13aca2e79
Author: Eoghan Glynn <email address hidden>
Date: Sat Apr 19 10:11:20 2014 +0100

    Use known protocol scheme in keystone tests

    With the recent introduction of the identity_uri in keystoneclient,
    there is a small backward incompatible change which means that weird
    protocols like the ones we use during tests aren't support properly
    anymore. The patch replaces "foottp" and "barttp" by "file" hopefully
    keeping testing coverage the same.

    Change-Id: Idb30ff3ee0ca50911e453899ad32e630f9b18724
    Closes-Bug: #1309092
    (cherry picked from commit e5b7606eaa94033256eb1aca5f6a6eed4f9e54a0)
    (cherry picked from commit a1ec218d683e27434a5b085f1fbc7e3c13b60684)