Alarms with combination_rule type should not accept only one alarm in alarm_ids list

Bug #1305519 reported by Ildiko Vancsa
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Low
Ildiko Vancsa

Bug Description

Combination rule type alarms should contain at least two alarms according to the definition: Describe when to trigger the alarm based on combining the state of other alarms. Currently it accepts only one item as a list of other alarms, which is misleading and also a waste of resources.

Changed in ceilometer:
assignee: nobody → Ildiko Vancsa (ildiko-vancsa)
importance: Undecided → Low
milestone: none → juno-1
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/88355

Changed in ceilometer:
status: New → In Progress
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/88355
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=6edc3fc4a71facd18e6d09bc1f2c5abdbdbbd09c
Submitter: Jenkins
Branch: master

commit 6edc3fc4a71facd18e6d09bc1f2c5abdbdbbd09c
Author: Ildiko Vancsa <email address hidden>
Date: Thu Apr 17 15:11:14 2014 +0200

    Improve combination rule validation

    Combination rule alarms should contain at least two different alarms
    in the alarm_ids list. This patch adds a check to the validate method
    of AlarmCombinationRule and raise ClientSideError, if the condition
    fails.

    Closes-Bug: #1305519

    Change-Id: Ic5968d6ecf5781070cab39274131e605619e264a

Changed in ceilometer:
status: In Progress → Fix Committed
Revision history for this message
ZhiQiang Fan (aji-zqfan) wrote :

I'm not sure if this patch will have upgrade issue, the scenario is: user already has alarms with only one alarm_id

but may be I'm too captious....

Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.