post body validation not working correctly with pecan

Bug #1220678 reported by Doug Hellmann
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Medium
Unassigned
WSME
Fix Released
Medium
Unassigned

Bug Description

In ceilometer we have had a problem with WSME doing the type conversion for us for POST bodies.

http://git.openstack.org/cgit/openstack/ceilometer/tree/ceilometer/api/controllers/v2.py#n576

It's not clear if this is a bug in WSME, something specific to the pecan adapter, or something about the way we're using the decorators for that function.

Revision history for this message
Feilong Wang (flwang) wrote :

Doug, why we need a new bug to track this issue? Since I have opened one: https://bugs.launchpad.net/wsme/+bug/1218760

Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

Fei Long, I think these are two separate issues. In this ticket I am trying to describe a case where WSME is not properly deserializing the incoming body of a POST. There's no error, the body is just give to us as a dict() instead of the complex type.

Revision history for this message
Feilong Wang (flwang) wrote :

Got it, Doug. I will continue keeping an eye on this. Thanks.

Revision history for this message
Julien Danjou (jdanjou) wrote :

Doug, it'd be great if you had a test case to reproduce this.

Changed in ceilometer:
status: New → Triaged
importance: Undecided → Medium
Changed in wsme:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to wsme (master)

Reviewed: https://review.openstack.org/50667
Committed: http://github.com/stackforge/wsme/commit/b67405d486a0d09abde6423818734bbb5a978bc4
Submitter: Jenkins
Branch: master

commit b67405d486a0d09abde6423818734bbb5a978bc4
Author: Julien Danjou <email address hidden>
Date: Wed Oct 9 17:07:40 2013 +0200

    Validate body when using Pecan

    This makes sure that when the body is decoded we run the validation
    process on it.

    Fixes-Bug: #1220678

    Change-Id: I765a6ce8c8097ef0e0a734804242e9fcee4ffbcf

Changed in wsme:
status: Triaged → Fix Committed
Revision history for this message
Ildiko Vancsa (ildiko-vancsa) wrote :

Hi,

Is this still a valid bug for Ceilometer?

Best Regards,
Ildiko

Revision history for this message
Steve Lewis (steve-lewis) wrote :

The fix for WSME was released 0.5b6

Changed in wsme:
status: Fix Committed → Fix Released
Revision history for this message
Steve Lewis (steve-lewis) wrote :

I verified that this dependency was updated in Icehouse before the b1 milestone

Changed in ceilometer:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.