Ceilometer i18n support isn't complete, messages should be wrapped by "_" function

Bug #1199678 reported by David Jia
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Low
ChenZheng

Bug Description

Ceilometer has enabled i18n support, but there are a lot of messages in source code aren't wrapped by "_" function, for example:

https://github.com/openstack/ceilometer/blob/master/ceilometer/api/app.py#L112

LOG.info('Starting server in PID %s' % os.getpid()) should be replace by LOG.info(_('Starting server in PID %s') % os.getpid())

those messages can't be captured into po file and translated.

we should keep consistency with Oslo codes, such as:

https://github.com/openstack/ceilometer/blob/master/ceilometer/openstack/common/service.py#L113

David Jia (jiataotj)
description: updated
David Jia (jiataotj)
description: updated
Revision history for this message
xingzhou (xingzhou) wrote :

There is still an indeterminacy for OpenStack i18n team on whether to support LOG level translation or not, because if we translate the LOGs, it might not be easy to search and locate errors,

Changed in ceilometer:
assignee: nobody → Justin Shepherd (jshepher)
Revision history for this message
David Jia (jiataotj) wrote :

Xing,

    Is there any i18n team work progress information on wiki page or public accessing place? I'd like to know the newest plan for LOGs tranlstaion.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/36774

Changed in ceilometer:
status: New → In Progress
Revision history for this message
David Jia (jiataotj) wrote :

@Doug Hellmann

Hi Doug,

    According to your comments for Review:https://review.openstack.org/36774, is there any blueprints or bug in Olso for log translation discussion? If yes, could you share the link? I'm curious about the discussion result. Thanks you!

Revision history for this message
Justin Shepherd (jshepher) wrote :

Un-assigning based on Doug's comments in https://review.openstack.org/36774

Changed in ceilometer:
assignee: Justin Shepherd (jshepher) → nobody
status: In Progress → New
Julien Danjou (jdanjou)
Changed in ceilometer:
status: New → Triaged
importance: Undecided → Low
Changed in ceilometer:
assignee: nobody → ChenZheng (czheng-2)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/54683
Committed: http://github.com/openstack/ceilometer/commit/7f542e3ac8c822bc0e5f1d5e7f9de3b7338a717d
Submitter: Jenkins
Branch: master

commit 7f542e3ac8c822bc0e5f1d5e7f9de3b7338a717d
Author: ChenZheng <email address hidden>
Date: Thu Oct 31 15:46:30 2013 +0800

    Add i18n warpping for all LOG messages

    Add i18n wrapping for all LOG messages

    Change-Id: I7f9c71a3aa76364b291f7e21a1737b927cbdc300
    Fixes: bug #1199678

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: none → icehouse-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.