Ceilometer tests fail with latest keystoneclient

[Thomas Herve]

When running with latest keystoneclient, about 11 tests fail with "TypeError: set() got an unexpected keyword argument 'timeout'". It's somewhat the same problem as bug #1113146, but the trivial change in tests/api/v2/acl.py to add the new keyword just make tests explode in a different fashion.

[Thomas Herve (therve)]

The problematic version seems to be python_keystoneclient-0.3.0, but tip is the same.

[Doug Hellmann (doug-hellmann)]

Example traceback from the failure:

======================================================================
FAIL: tests.api.v2.test_impl_sqlalchemy.TestAPIAcl.test_with_non_admin
tags: worker-0
----------------------------------------------------------------------
pythonlogging:'': {{{
Starting keystone auth_token middleware
Using /tmp/keystone-signing-6K5T0c as cache directory for signing certificate
Using fake.cache memcache for caching token
}}}

Traceback (most recent call last):
  File "/opt/stack/ceilometer/tests/api/v2/acl.py", line 175, in test_with_non_admin
    'value': 'project-good',
  File "/opt/stack/ceilometer/tests/api/v2/acl.py", line 114, in get_json
    **params)
  File "/opt/stack/ceilometer/ceilometer/tests/api.py", line 164, in get_json
    expect_errors=expect_errors)
  File "/opt/stack/ceilometer/.tox/py27/local/lib/python2.7/site-packages/webtest/app.py", line 199, in get
    expect_errors=expect_errors)
  File "/opt/stack/ceilometer/.tox/py27/local/lib/python2.7/site-packages/webtest/app.py", line 467, in do_request
    res = req.get_response(app, catch_exc_info=True)
  File "/opt/stack/ceilometer/.tox/py27/local/lib/python2.7/site-packages/webob/request.py", line 1292, in send
    application, catch_exc_info=True)
  File "/opt/stack/ceilometer/.tox/py27/local/lib/python2.7/site-packages/webob/request.py", line 1260, in call_application
    app_iter = application(self.environ, start_response)
  File "/opt/stack/ceilometer/.tox/py27/local/lib/python2.7/site-packages/webtest/lint.py", line 198, in lint_app
    iterator = application(environ, start_response_wrapper)
  File "/opt/stack/ceilometer/.tox/py27/local/lib/python2.7/site-packages/keystoneclient/middleware/auth_token.py", line 459, in __call__
    token_info = self._validate_user_token(user_token)
  File "/opt/stack/ceilometer/.tox/py27/local/lib/python2.7/site-packages/keystoneclient/middleware/auth_token.py", line 710, in _validate_user_token
    self._cache_store_invalid(user_token)
  File "/opt/stack/ceilometer/.tox/py27/local/lib/python2.7/site-packages/keystoneclient/middleware/auth_token.py", line 961, in _cache_store_invalid
    self._cache_store(token, 'invalid')
  File "/opt/stack/ceilometer/.tox/py27/local/lib/python2.7/site-packages/keystoneclient/middleware/auth_token.py", line 928, in _cache_store
    timeout=self.token_cache_time)
TypeError: set() got an unexpected keyword argument 'timeout'

[Doug Hellmann (doug-hellmann)]

https://review.openstack.org/#/c/34573/

[Dolph Mathews (dolph)]

The logging and backtrace above indicates that something like memcachering ("fake.cache") is being consumed from the environment rather than using openstack.common.memorycache -- is that intentional?

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/34573
Committed: http://github.com/openstack/ceilometer/commit/1ba1bc7edaba9c4b8cdd9ffdff7c4ea121fc8bd1
Submitter: Jenkins
Branch: master

commit 1ba1bc7edaba9c4b8cdd9ffdff7c4ea121fc8bd1
Author: Doug Hellmann <email address hidden>
Date: Wed Jun 26 11:51:44 2013 -0400

    Pin the keystone client version

    Addresses but does not fix bug # 1194921

    Change-Id: I1112f18b7545e90c322dde00b8d08dae6273c9bb
    Signed-off-by: Doug Hellmann <email address hidden>

[Dolph Mathews (dolph)]

This looks like it would be fixed on the python-keystoneclient side by https://review.openstack.org/#/c/33849/

If so, then I'll cut v0.3.1 after that merges and we can unpin ceilometer

[Adam Gandelman (gandelman-a)]

@Dolph- Looks like that was merged. Any chance of a v0.3.1 so we can unpin the keystoneclient requirement in ceilometer + cinder?

[Dolph Mathews (dolph)]

@Adam: working on that now.

[Dolph Mathews (dolph)]

Removed keystoneclient from this bug, as this was effectively fixed by releasing keystoneclient v0.3.1 which included a fix for bug 1193032.