incorrect return of get_raw_events() in sqlalchemy implementation

Bug #1101100 reported by Lianhao Lu
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Undecided
Lianhao Lu

Bug Description

According to the storage/base.py, the abstract method Connection.get_raw_events() should return an iterable of raw events data created by ceilometer.collecotr.meter.meter_message_from_counter().

But in current sqlalchemy implementation, the returned raw events data by get_raw_events() is not compatible with that created by meter_message_from_counter().

Lianhao Lu (lianhao-lu)
Changed in ceilometer:
assignee: nobody → Lianhao Lu (lianhao-lu)
Changed in ceilometer:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/20014
Committed: http://github.com/openstack/ceilometer/commit/83ef54a891890b82eb208be28d8790b2bbf5f74a
Submitter: Jenkins
Branch: master

commit 83ef54a891890b82eb208be28d8790b2bbf5f74a
Author: Lianhao Lu <email address hidden>
Date: Fri Jan 18 14:27:21 2013 +0800

    Higher level test for db backends.

    This patch implemented the blueprint test-db-backends, and also fixed
    the bug 1085111.

    Note: Some test cases in RawEventTest are still db backend dependendant
    due to the bug 1101100. We could move them to base class after we
    resolve that bug.

    Change-Id: Ic32a7f0719d34a008cc21ddd59c9912d9a90db24

Changed in ceilometer:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/20215
Committed: http://github.com/openstack/ceilometer/commit/ce1a4b57a544917a19d08f0bf0d02fc97f5e3bec
Submitter: Jenkins
Branch: master

commit ce1a4b57a544917a19d08f0bf0d02fc97f5e3bec
Author: Lianhao Lu <email address hidden>
Date: Tue Jan 22 16:45:48 2013 +0800

    Corrected get_raw_event() in sqlalchemy.

    This fixed bug 1101100. The returned dict of get_raw_event() in sqlalchemy
    should be consistent with one generated by
    collector.meter.meter_message_from_counter().

    Change-Id: I6948fdbd0c1e03d46be7d3a05faa53ca70698ce8

Thierry Carrez (ttx)
Changed in ceilometer:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.