the notification message payload for delete events should include all metadata

[Doug Hellmann]

As we discussed at the Grizzly summit last week, the notification messages generated by quantum should include all of the metadata for the resource so ceilometer can consume the information. We are currently looking for events for network, subnet, and port objects with routers coming soon.

[dan wendlandt (danwent)]

Mark, can this be bumped to havana, or is something actually broken if we don't fix it?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/85661

[Ziba (z-launchpadrz)]

Hi,
I wanted to share my development to fix this bug. Actually, I've only worked on this bug when a subnet is deleted. This is why you can find reference to subnetDetails in the neutron code. This would have to be changed.
I have made changed to python-neutronclient too. The method "delete_subnet" calls "show_subnet" to retrieve the tenant_id owning the subnet. Then the neutron Client sends this information to Neutron while deleting the subnet.
I have not commited my work on python-neutronclient because it does not pass the unit tests: Connection to Neutron Failed.
I guess that the call of the method "show_subnet" in the method "delete_subnet" has to be mocked but I don't know if I can change the unit tests.

I would be glad to get your point of views, comments...

Best regards,
Romain.

[Akihiro Motoki (amotoki)]

@Ziba,

I think we need to share the notification API to be implemented before starting the review.
Long time goes since the initial bug report was registered and I believe it is a time to do so.

The bug description says "the notification messages generated by quantum should include all of the metadata for the resource so ceilometer can consume the information.", but according to your patch only tenant_id is notified in subnet.delete.start notification. I am not sure it addresses the issue completely.

Regarding neutronclient, I don't think we need to change neutronclient. In general, a content of notification message should not depend on a content of a request and it should be retrieved from neutron db to ensure the notification can be trusted.

[Ziba (z-launchpadrz)]

@Motoki,

thanks for your update. I have re-designed my code and I have changed the neutron/db/db_base_plugin.py to return the tenant_id in the delete_subnet method. I use it then in the delete method of neutron/api/base.py but only for subnet.delete.end notifications this time.
I've tested it functionnaly and Ceilometer does not complain that only tenant_id is provided. But I agree it might not work for other methods. It's the first time I contribute to Openstack so forgive me if I've done something wrong. I just want to provide my work for the community as I need to fix this bug for my own purposes.
Please tell me if you want me to git-review my new code or not.

Thanks & best regards,
Romain.

[gordon chung (chungg)]

@igor, please check with Pradeep as he originally put some code in on neutron side.

https://review.openstack.org/#/c/91474/
https://review.openstack.org/#/c/91686/

[Igor Degtiarov (idegtiarov)]

Thanks gordon will do.

[Nelly (nelly-smitt)]

I can finish the work if no one is busy with the bug :)

[Dina Belova (dbelova)]

Nelly is new OPW intern candidate and she really needs to contribute now, so I guess nobody will have the objections here to allow her to finish this work.

Cheers!
Dina