add self- enable/disable check on plugin load

Bug #1021350 reported by Doug Hellmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Wishlist
Doug Hellmann

Bug Description

The original architecture design document proposed asking plugins at startup whether or not they should be enabled to avoid polling them later when we know they cannot (or will not) return any useful data. That was never implemented, and needs to be.

Nick Barcet (nijaba)
Changed in ceilometer:
status: New → Confirmed
importance: Undecided → Wishlist
tags: added: agent collector effort-s
Changed in ceilometer:
assignee: nobody → justin thomas simms (jsimms)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/13184

Changed in ceilometer:
assignee: justin thomas simms (jsimms) → Doug Hellmann (doug-hellmann)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/14972

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/14972
Committed: http://github.com/stackforge/ceilometer/commit/ae64a792f8ac9a1e0969b205018d219fbaea05db
Submitter: Jenkins
Branch: master

commit ae64a792f8ac9a1e0969b205018d219fbaea05db
Author: Doug Hellmann <email address hidden>
Date: Mon Oct 29 09:31:52 2012 -0400

    Use stevedore to load all plugins

    Move away from calling pkg_resources directly to use
    stevedore to load plugins. This lays the ground work
    for handling disabled plugins during the loading
    phase.

    addresses bug #1021350

    Change-Id: I94c2d0da2a6f9222611716b96455104a71564f29
    Signed-off-by: Doug Hellmann <email address hidden>

Changed in ceilometer:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/14973
Committed: http://github.com/stackforge/ceilometer/commit/05d6992ad778e802ef3aa1e406dce7d18606c3a1
Submitter: Jenkins
Branch: master

commit 05d6992ad778e802ef3aa1e406dce7d18606c3a1
Author: Doug Hellmann <email address hidden>
Date: Mon Oct 29 11:41:53 2012 -0400

    Provide a way to disable some plugins

    Provide configuration options for the three plugin sets
    users may want to manage (compute pollsters, central
    pollsters, and notification listeners).

    Extend the plugin API so the extension manager can ask
    each plugin if it should be enabled. This allows, for
    example, the libvirt pollster to be loaded but then
    recognize that it should not be used and disable itself.

    Addresses bug #1021350

    Change-Id: I82da823845ec49c1a93272411c43073bd4954377
    Signed-off-by: Doug Hellmann <email address hidden>

Thierry Carrez (ttx)
Changed in ceilometer:
milestone: none → grizzly-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: grizzly-2 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.