Openstack-Cloud-Controller-Manager doesn't use the cluster-name

[Adam Dyess]

As demonstrated in https://pastebin.canonical.com/p/NFk9k9zgTF/ the args of openstack-cloud-controller-manager

    Args:
      /bin/openstack-cloud-controller-manager
      --cluster-name=kubernetes-fu6ks9empuz38g7utkc1n6unudbn9dc1
      --v=1
      --cluster-name=$(CLUSTER_NAME)
      --cloud-config=$(CLOUD_CONFIG)
      --cloud-provider=openstack
      --use-service-account-credentials=true
      --bind-address=127.0.0.1

set the cluster-name twice -- which ends up using the environment set name instead since it comes second in the argument list.

The DaemonSet default value for cluster-name is `kubernetes` -- meaning that if you were to use two or more clusters attached to the same openstack cloud project, all the resources intended to be unique for your cluster would clash with the second cluster.

for example:

A loadbalancer for the hello service in the default domain might be named kube_service_kubernetes-default-hello

Both clusters would attempt to use this same load-balancer for the different services each named hello

[Adam Dyess (addyess)]

Affects
* cdk-addons 1.28
* cdk-addons 1.27
* cdk-addons 1.26

Does not affect cdk-addons 1.25 or Prior

[Adam Dyess (addyess)]

Resolve with
https://github.com/charmed-kubernetes/cdk-addons/pull/227

[Pedro Victor Lourenço Fragola (pedrovlf)]

I tested a workaround by changing the daemonset "kubectl edit daemonset -n kube-system openstack-cloud-controller-manager" to use the correct cluster name:

1001 345683 345576 9 20:44 ? 00:00:01 /bin/openstack-cloud-controller-manager --cluster-name=kubernetes-fu6ks9empuz38g7utkc1n6unudbn9dc1 --v=1 --cluster-name=kubernetes-fu6ks9empuz38g7utkc1n6unudbn9dc1 --cloud-config=/etc/config/cloud.conf --cloud-provider=openstack --use-service-account-credentials=true --bind-address=127.0.0.1

With this, the LB is created with the right name:

| 03f1a0e3-68cf-45da-ab76-10c45b5f01e4 | kube_service_kubernetes-fu6ks9empuz38g7utkc1n6unudbn9dc1_default_microbot-service-test | f98f4210a9764fff93ed4bd58b710025 | 10.6.1.117 | PENDING_CREATE | OFFLINE | amphora |

[Adam Dyess (addyess)]

We will likely need to target backport fixes for 1.28, 1.27, and 1.26

[Adam Dyess (addyess)]

Fix for the charm
https://github.com/canonical/openstack-cloud-controller-operator/pull/5

[Adam Dyess (addyess)]

Backports:
1.26 https://github.com/charmed-kubernetes/cdk-addons/commit/8952c41617f15641c7d7666dc522d2bf98b7d42b
1.27 https://github.com/charmed-kubernetes/cdk-addons/commit/7e21da8006d18f97308fcd49628b9413ef872c8d
1.28 https://github.com/charmed-kubernetes/cdk-addons/commit/0195dc310136d80f2e66cb2bb70f05cd915cdaa7