Verify Job Xml has the required elements (or automatically add them)

[Caio Begotti]

We require a notification plugin element, we could verify that uploaded job xml documents have the necessary elements (or insert them).

From https://github.com/capomastro/capomastro/issues/3

[Daniel Manrique (roadmr)]

I'm not sure why the notification plugin element is required. Also, who does the verification? jenkins or capomastro? If capomastro, we'd have a better idea of where/how to add these things.

I'll set to incomplete so we can discuss this one a bit.

[Caio Begotti (caio1982)]

I think their original idea was to avoid an import of a jobtype into Jenkins with invalid XML data (thus the mention about Notification element), and I suppose it would be Capomastro's job to verify it as the importing is done through it.

[Daniel Manrique (roadmr)]

ohh fun. So we need capomastro to parse the xml (lxml here we go) and ensure it has the required parameters, and if not, add them itself, or just barf and warn the user? Regardless of behavior, this is clearer now, I think. I'd be interested in seeing whether an xml file produced by lxml still makes jenkins happy. It should!