Don't launch capnet with 404 or time out

Bug #1536418 reported by Danielle Foré
26
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Captive Portal Assistant
Fix Released
High
Unassigned

Bug Description

We were talking about how to avoid error with capnet showing when it's not supposed to and we realized a problem:

If capnet received a 404 (not found) or 408 (timeout) then it most certainly will not render a captive portal when launched. So for these two cases, we should not launch capnet since it would be useless.

Related branches

Changed in capnet-assist:
milestone: none → loki-beta1
Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

Confirmed in-person with Dan at SCALE. :)

Changed in capnet-assist:
status: New → Confirmed
Cody Garver (codygarver)
Changed in capnet-assist:
importance: Undecided → High
Revision history for this message
Gustavo Puy (info-gustavopuy) wrote :

I'll add "sudo chmod -x etc/NetworkManager/dispatcher.d/90captive_portal_test" until bug where fixed.

That script waits for process nm-applet to start browser but I think there's not the correct approach. Something like resolve an URL before launch browser would be better.

Changed in capnet-assist:
milestone: loki-beta1 → none
Cody Garver (codygarver)
Changed in capnet-assist:
milestone: none → loki-rc1
status: Confirmed → Fix Committed
Cody Garver (codygarver)
Changed in capnet-assist:
milestone: loki-rc1 → 0.2
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.