Don't launch capnet with 404 or time out
Bug #1536418 reported by
Danielle Foré
This bug affects 4 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Captive Portal Assistant |
Fix Released
|
High
|
Unassigned |
Bug Description
We were talking about how to avoid error with capnet showing when it's not supposed to and we realized a problem:
If capnet received a 404 (not found) or 408 (timeout) then it most certainly will not render a captive portal when launched. So for these two cases, we should not launch capnet since it would be useless.
Related branches
lp:~matzipan/capnet-assist/no-internet-fix
- Zisu Andrei (community): Approve (test)
-
Diff: 61 lines (+17/-8)1 file modifiedsrc/CaptiveLogin.vala (+17/-8)
Changed in capnet-assist: | |
milestone: | none → loki-beta1 |
Changed in capnet-assist: | |
importance: | Undecided → High |
Changed in capnet-assist: | |
milestone: | loki-beta1 → none |
Changed in capnet-assist: | |
milestone: | none → loki-rc1 |
status: | Confirmed → Fix Committed |
Changed in capnet-assist: | |
milestone: | loki-rc1 → 0.2 |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Confirmed in-person with Dan at SCALE. :)