FTBFS

[Robert Collins]

make[3]: Entering directory `/home/robertc/source/canonical/dx/indicator-custom/src'
  CC libcustom_la-indicator-custom.lo
indicator-custom.c:5: error: expected declaration specifiers or ‘...’ before string constant
cc1: warnings being treated as errors
indicator-custom.c:7: error: return type defaults to ‘int’
indicator-custom.c: In function ‘INDICATOR_SET_NAME’:
indicator-custom.c:9: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘{’ token
indicator-custom.c:15: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘{’ token
indicator-custom.c:21: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘{’ token
indicator-custom.c:28: error: expected ‘{’ at end of input

INDICATOR_SET_NAME is not defined in the libindicator 0.3 headers, and the other errors are a cascade from that missing define.

Ted, what direction should I head in to fix this? Are names deprecated/deleted? Exposed over DBUS now? something else?

[Ted Gould (ted)]

On Tue, 2009-11-17 at 02:40 +0000, Robert Collins wrote:
> Ted, what direction should I head in to fix this? Are names
> deprecated/deleted? Exposed over DBUS now? something else?

It's fixed on a feature branch that isn't merged in... so I think that
ignoring it is really the solution :)

[Robert Collins (lifeless)]

On Tue, 2009-11-17 at 15:23 +0000, Ted Gould wrote:
> On Tue, 2009-11-17 at 02:40 +0000, Robert Collins wrote:
> > Ted, what direction should I head in to fix this? Are names
> > deprecated/deleted? Exposed over DBUS now? something else?
>
> It's fixed on a feature branch that isn't merged in... so I think that
> ignoring it is really the solution :)

Can we merge it in? Or that component anyhow? Build failures in trunk
are pretty important to fix ASAP.

-Rob

[Ted Gould (ted)]

On Tue, 2009-11-17 at 22:47 +0000, Robert Collins wrote:
> On Tue, 2009-11-17 at 15:23 +0000, Ted Gould wrote:
> > On Tue, 2009-11-17 at 02:40 +0000, Robert Collins wrote:
> > > Ted, what direction should I head in to fix this? Are names
> > > deprecated/deleted? Exposed over DBUS now? something else?
> >
> > It's fixed on a feature branch that isn't merged in... so I think that
> > ignoring it is really the solution :)
>
> Can we merge it in? Or that component anyhow? Build failures in trunk
> are pretty important to fix ASAP.

Uhm, sure, the feature it's implementing isn't really complete though.
I mean the problem is that the upstream library changed and we haven't
made the corresponding change. So it's not really a "trunk problem" as
much as an environment problem.

[Mark Shuttleworth (sabdfl)]

Nevertheless, please can you ensure we always have a pristine trunk that
builds and works. Right now, I'm using the daily PPA, and your
indicators all crash on login and fail to come back.

Mark

[JLR (artirj)]

Is this one of the new indicators slated for Lucid?