Setting a surface keymap crashes in xkbcommon: xkb_keymap_new_from_names()

[Lukáš Tinkl]

Trying to set a keymap on a Mir surface crashes somewhere between Mir and xkbcommon with this backtrace:

http://paste.ubuntu.com/14399228/

Code from: https://code.launchpad.net/~lukas-kde/qtmir/kbdLayout and https://code.launchpad.net/~lukas-kde/unity8/kbdLayout

The xkb_names structure (four char*) is sent over the wire as four addresses. Our tests do not fail because they use the in process client..

[Alberto Aguirre (albaguirre)]

Have you tried using empty strings instead of null for unused fields?

[Lukáš Tinkl (lukas-kde)]

Yup, similar crash

[Alberto Aguirre (albaguirre)]

so I hacked TestClientInput.clients_receive_keymap_change_events (tests/acceptance_tests/test_client_input.cpp) to do:

 xkb_rule_names names;
  names.rules = nullptr;
  names.model = nullptr;
  names.layout = "us";
  names.variant = nullptr;
  names.options = nullptr;

EXPECT_CALL(first_client, handle_keymap(_))
        .Times(1)
        .WillOnce(mt::WakeUp(&first_client.all_events_received));

server.the_shell()->focused_surface()->set_keymap(names);
first_client.all_events_received.wait_for_at_most_seconds(2);

No crash.

Can you examine xkb_rule_names and list the contents?

[PS Jenkins bot (ps-jenkins)]

Fix committed into lp:mir at revision 3266, scheduled for release in mir, milestone 0.20.0

[Daniel van Vugt (vanvugt)]

mir (0.19.0+16.04.20160128-0ubuntu1) xenial; urgency=medium