SSH key page shows import banner

[Tom Wardill]

Under the vanilla layout, the 'SSH keys' pages shows a banner telling me that I need to set a username before adding a key.

There are two problems with this.
1. I already have set a username, so why does this banner show?
2. If I haven't set a username, why are the controls to add a key enabled?

[Karl Williams (deadlight)]

Re: 1., The form generation code passes the "unset username" error to the template and this has not changed with the frontend conversion to using Vanilla. Perhaps this is more of an artefact of the environment? Maybe more testing is needed.

Re: 2., I will make sure that the form submission button is disabled when the rest of the form is. (Perhaps, as a later enhancement, we can consider not showing the form at all if the user cannot add a key)

[Daniel Manrique (roadmr)]

Hey Tom,

Can you please provide more details on a repro case for this? I wasn't able to on staging, maybe because staging and production force users to have a username.

If that's the case, a repro case maybe with a local install would help, but we can also lower the priority since it wouldn't affect deployed public instances.

[Daniel Manrique (roadmr)]

On staging, it does not show the form if you don't have a username setting, and while the error messages show, they do point to what you need to do (set a username) in order to be able to add keys.