Canonical SSO provider

After choosing “Log in or Create Account”, you aren’t returned to the correct site

Bug #1667666 reported by Matthew Paul Thomas
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical SSO provider
Fix Released
High
Colin Watson

Bug Description

1. In a private browser window, go to a site that requires Ubuntu One sign-in. For example, <https://build.snapcraft.io/> or <https://calendar.canonical.com/>.
2. Follow the sign-in link/button.
3. Choose “Log in or Create Account”.
4. Create a new account.

What happens:
4. After creating your account, you’re dumped on the Ubuntu One profile page.

What should happen: either
3. There is no “Log in or Create Account” link on this particular page at all, or
4. After your creating your account, you are still returned to the original site.

Related branches

lp:~cjwatson/canonical-identity-provider/more-token-links
Maximiliano Bertacchini: Approve
Diff: 730 lines (+258/-67)
20 files modified
src/identityprovider/emailutils.py (+2/-2)
src/identityprovider/tests/test_emailutils.py (+15/-1)
src/identityprovider/tests/test_views_server.py (+4/-3)
src/identityprovider/views/server.py (+2/-1)
src/webui/templates/account/edit.html (+2/-4)
src/webui/templates/account/emails.html (+5/-5)
src/webui/templates/common/forgot_password_link.html (+2/-4)
src/webui/templates/common/new_account_link.html (+2/-4)
src/webui/templates/common/unverified_email_warning.html (+2/-2)
src/webui/templates/registration/_create_account_form.html (+2/-4)
src/webui/templates/registration/_login_form.html (+2/-4)
src/webui/templates/registration/email_sent.html (+3/-2)
src/webui/templates/widgets/header-me-menu.html (+4/-3)
src/webui/templates/widgets/personal-menu.html (+2/-5)
src/webui/templatetags/url_with_token.py (+37/-0)
src/webui/tests/test_templates.py (+37/-1)
src/webui/tests/test_templatetags.py (+36/-1)
src/webui/tests/test_views_account.py (+83/-7)
src/webui/urls.py (+3/-1)
src/webui/views/account.py (+13/-13)
Colin Watson (cjwatson)
Changed in canonical-identity-provider:
assignee: nobody → Colin Watson (cjwatson)
status: New → In Progress
importance: Undecided → High
Revision history for this message
Daniel Manrique (roadmr) wrote :

Related to https://bugs.launchpad.net/canonical-identity-provider/+bug/1169632. Note the behavior implemented in that one's fix will email you a link that will take you back to the RP once verified, but you're correct that the page you're dumped to when registering doesn't have a reference back to the RP. Anyway, just linking to the other bug for reference.

Colin Watson (cjwatson)
Changed in canonical-identity-provider:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.