wrong field activated in https://login.launchpad.net/*code*/+decide

[Manfred Hampl]

It seems to me that a few days ago there must have been a change in the Launchpad login (Ubuntu One login) dialogue.

In the past whenever logging in with username and password on the launchpad.net/+login page, the following page ("Personal Data Request - Launchpad has requested some personal information..." had the cursor already on the "Yes, log me in" button, that a simple press on the "Enter" key completed the login process.

Nowadays the cursor is positioned on some other field, such that you have to switch over from the keyboard to the mouse to click the button, or you have to press "Tab" ten times, and only then can use the "Enter" key to confirm the login action.

Is this change on purpose? Is it reasonable to request a modification back to the old behavior?

(I have created a question about this in "Launchpad itself", which was moved to "Canonical SSO provider" and did not get any attention until it expired. This is why I now create a bug report.)

[Manfred Hampl (m-hampl)]

The "few days ago" must have been early June 2015.

[Daniel Manrique (roadmr)]

OK, this happened in revision 1273 of the canonical-identity-provider trunk, which was committed on May 13th.

A bunch of Javascript code was removed to make clicking on the checkboxes more reliable. Unfortunately this snippet (which affects the behavior described in this bug) was also removed:

<script>
    document.decideform.yes.focus();

A possible fix is to restore *just* that one-liner snippet:

=== modified file 'src/identityprovider/templates/server/decide.html'
--- src/identityprovider/templates/server/decide.html 2015-05-13 18:51:03 +0000
+++ src/identityprovider/templates/server/decide.html 2015-06-29 16:12:17 +0000
@@ -79,3 +79,9 @@
     </div>
     <br style="clear: both" />
 {% endblock %}
+
+{% block extra_js %}
+ <script>
+ document.decideform.yes.focus();
+ </script>
+{% endblock %}

but I'll need to ensure it doesn't regress the "flaky checkboxes" behavior the rest of the code was meant to fix.

[Manfred Hampl (m-hampl)]

Works again as desired, thanks.