Lack of memcached oopses login
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical SSO provider |
New
|
Undecided
|
Unassigned |
Bug Description
If memached is unavailable for any reason, login fails in the rate limiting code.
It would be better if sso handled this more gracefully, albiet with degraded functionality.
ValueError "Key ':1:rl-
File "/srv/login.
response = wrapped_
File "/srv/login.
return self.dispatch(
File "/srv/login.
return bound_func(*args, **kwargs)
File "/srv/login.
return func(request, *args, **kwargs)
File "/srv/login.
return func(self, *args2, **kwargs2)
File "/srv/login.
return bound_func(*args, **kwargs)
File "/srv/login.
response = func(request, *args, **kwargs)
File "/srv/login.
return func(self, *args2, **kwargs2)
File "/srv/login.
return bound_func(*args, **kwargs)
File "/srv/login.
return self.view_
File "/srv/login.
self.
File "/srv/login.
cache.incr(key)
File "/srv/login.
return method(*args, **kw)
File "/srv/login.
raise ValueError("Key '%s' not found" % key)
Please make sure there are unit tests that validate that everything still works with and without memcache.
There are examples of that in ubuntuone-servers from the matvu days.