adb reboot fails: "reboot failed: -1" with xenial

[Michał Sawicz]

Steps:
* flash ubuntu-touch/staging/ubuntu on frieza or krillin
* adb reboot

Expected:
* device reboots

Current:
* prints "reboot failed: -1"

[Timo Jyrinki (timo-jyrinki)]

Yeah this is how it is on xenial. Also means a need to manually to put the device to eg fastboot mode if necessary, or recovery mode in order to upgrade image.

[Chunsang Jeong (chunsang)]

Currently, "adb reboot" only reboot android container, so after "adb reboot" commands turn off android container, second try of adb reboot returns "reboot failed: -1" all the time because adbd failed to read "sys.powerctl" from android container.

android-tools-adbd-reboot-watcher.conf is supposed to get "sys.powerctl" from android container before it reboots and do /sbin/reboot to reboot ubuntu but it doesn't run successfully, which I'm looking into.

[Chunsang Jeong (chunsang)]

Even changing sys.powerctl from android container, didn't make android-toos-adbd-reboot-watcher start which triggers sys.powerctl=reboot*

 start on android-container sys.powerctl=reboot*

$ initctl list | grep reboot-watcher
android-tools-adbd-reboot-watcher stop/waiting

From vivid, the status changed while running script if sys.powerctl is set reboot*.
$ initctl list | grep reboot-watcher
android-tools-adbd-reboot-watcher start/running

[Ondrej Kubik (ondrak)]

abd reboot from Ubuntu has following steps:
1) adbd sets android property "sys.powerctl" to "reboot"/"reboot recovery" or any supported value
2) this is picked by Android inside container, and Android shuts down in controlled way
3) on Ubuntu side we have Upstart job /etc/init/android-tools-adbd-reboot-watcher.conf
   which is waiting for Android property "sys.powerctl" change, when value "reboot*" is detected, it waits for 1 second to give Android time to finish shut down, and then it executes "/sbin/reboot -f <optional value>" to reboot Ubuntu.

As Chunsang mentioned, calling adb reboot twice, will result in error, as Android is shut down and adbd fails to even change value of Android property "sys.powerctl" and returns error "reboot failed: %d".

Considering Chunsang's findings we have first 2 steps working.
For third step there could be 2 reasons for reboot not working:
- upstart job is not picking android property change
  this could be caused, either by Android side (upstart-property-watcher is not working) or upstart is broken and does not parse property changes correctly.
  We can have race between UpstartPropertyWatcher signalling to upstart and Android shutting down. upstart-property-watcher logs to logcat with tag "UpstartPropertyWatcher", so we should be able to see "sys.powerctl" change in logs, if it's missing then we have race condition on Android side.
Otherwise we can add trace to /etc/init/android-tools-adbd-reboot-watcher.conf to see if signal is received by upstart script.

- /sbin/reboot -f does not work
 - this could be easily tested by running /sbin/reboot -f from shell manually

Either way, this is very upstart related, so so considering we are moving to systemd, we might give this bug lover priority unless easy fix......

[Paul Larson (pwlars)]

Anyone still working on this? I can reproduce this easily on a m10 tablet that we are trying to use for automated testing, and it's a bit of a blocker to our automation.

[dinamic (dinamic6661)]

can reproduce this on m10, staging r138

[Chunsang Jeong (chunsang)]

It happened only when using systemd as commented at #4.

Please share info which device and version it still happens from? and can try ad-hoc way as "adb shell /sbin/reboot -f" before everything is settled down?