[needs-packaging] repowerd needs packaging
Bug #1599271 reported by
Alexandros Frantzis
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
Wishlist
|
kevin gunn | ||
repowerd (Ubuntu) |
Fix Released
|
Wishlist
|
Unassigned |
Bug Description
repowerd (https:/
repowerd is in the process of being released through ci-train here:
https:/
Related branches
description: | updated |
Changed in canonical-devices-system-image: | |
status: | New → Fix Committed |
importance: | Undecided → Wishlist |
assignee: | nobody → kevin gunn (kgunn72) |
milestone: | none → 13 |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
A few minor comments:
- The upstream version is 2016.06. But citrain already appends the date as part of the version. So unless you plan to make a habit of updating the upstream version, you may eventually get to versions like 2016.06+ 17.10.20180705, which has three different dates in it, all different. This isn't a *problem*, just pointing it out. May become confusing.
- Vcs-Git in debian/control should be "https:/ /git.launchpad. net/repowerd" (or lp:repowerd, if git understands that?)
- It is more proper for the powerd dummy package to be "Arch: any" since it points at an "any" package.
- I see REPOWERD_ DISABLE_ TIME_SENSITIVE_ TESTS=ON in debian/rules. Is there something that does run the time sensitive tests? CI Jenkins maybe? This might be a good spot to suggest adding a dep8 test that runs the full test suite.
- dh_installinit seems to be a little confused? It inserts code into postinst and prerm to stop and start the init.d job. But repowerd only installs an upstart job and a systemd job...
Otherwise the packaging seems fine.