Impossible to visually separate determinate and indeterminate ProgressBars where showProgressPercentage is false

Bug #1587176 reported by Jonas G. Drange
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Committed
High
Zoltan Balogh
ubuntu-ui-toolkit (Ubuntu RTM)
Fix Released
High
Zsombor Egri

Bug Description

Reproduce:
I want to create a indeterminate ProgressBar where showProgressPercentage is set to false, so as to implement a part of the visual spec for Ubuntu System Settings [2].

See test case [1].

What happens:
It is not possible to separate these ProgressBars:

    ProgressBar {
        …
        indeterminate: true
        showProgressPercentage: false
        …
    }

    ProgressBar {
        …
        indeterminate: false
        showProgressPercentage: false
        value: 0
        …
    }

What should happen:
A indeterminate progress bar without any text (see [2]) should not be identical to a determinate progress bar at 0% without any text.

If this was by design, it can be noted in the docs [3] to avoid confusion.

[1] http://pastebin.ubuntu.com/16849244/
[2] http://i.imgur.com/pFHiHVg.png
[3] https://developer.ubuntu.com/api/apps/qml/sdk-15.04.1/Ubuntu.Components.ProgressBar/

Related branches

summary: Impossible to visually separate determinate and indeterminate
- ProgressBar without showProgressPercentage
+ ProgressBars where showProgressPercentage is false
Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

As the new designs call for such a progress bar, I'm elevating this bug to CDSI. Fix should be trivial (just revert to the old indeterminate visual).

Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

Like to get the new updates panel finished this update

Changed in canonical-devices-system-image:
assignee: nobody → Zoltan Balogh (bzoltan)
importance: Undecided → High
milestone: none → 13
status: New → Confirmed
Changed in ubuntu-ui-toolkit (Ubuntu RTM):
assignee: nobody → Zsombor Egri (zsombi)
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

(For the avoidance of doubt, this is not by design. The progress bar spec states that a progress bar should never include a percentage, or any other text, in the first place.)

Revision history for this message
Zsombor Egri (zsombi) wrote :

Matthew, indeed, also the progress bar indeterminate should be different by design :)

Revision history for this message
Zsombor Egri (zsombi) wrote :

And Matthew, we may still show the percentage as we have the property for it. We can deprecate it, yes, but we still have to support the visuals for it.

Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit (Ubuntu RTM):
importance: Undecided → High
status: New → In Progress
Changed in canonical-devices-system-image:
status: Confirmed → In Progress
Changed in canonical-devices-system-image:
milestone: 13 → backlog
Revision history for this message
Łukasz Zemczak (sil2100) wrote :
Download full text (3.8 KiB)

This bug was fixed in the package ubuntu-ui-toolkit 1.3.2104+15.04.20160919.3 in https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/stable-phone-overlay

---------------

ubuntu-ui-toolkit (1.3.2104+15.04.20160919.3) vivid; urgency=medium

  [ Andrea Bernabei ]
  * Scrollbar: more hover related bugfixes and unit tests.
    Fixes: LP: #1616868, LP: #1616926

  [ Christian Dywan ]
  * QuickUtils.rootObject() needs to handle QQuickWindow. Fixes: LP: #1617745
  * Correctly test and fix trigger override of ComboButton. Fixes: LP: #1614045

  [ Zoltan Balogh ]
  Increase the top marging when scrolling upwards. Fixes LP: 1618581

  [ Timo Jyrinki ]
  * Temporarily skip unit tests on xenial while not all MPs to fix Qt 5.6 issues
    have landed yet.

  [ Michael Terry ]
  * Make ActivityIndicator spinner blue instead of orange. Fixes: LP: #1577828.

  [ Loïc Molinari ]
  * Changed src/ directory layout. Made the source directory layout consistent
    with Qt libs. The C++ libraries have been moved to src/ and the QML modules
    to src/imports/. That also makes it easier to differentiate between modules
    and libraries since we have a bunch of them now.
  * Moved internal tools meant to generate code for the toolkit lib from the QML
    module directory to the lib directory where it makes more sense.
  * Fixed the build as a Qt submodule.
  * Fixed, cleaned up and standardised header inclusions. Apart from the clean
    up and the readability improvements, this fixes a bunch of broken private
    header inclusions (#include "foo_p.h" in private headers instead of
    "private/foo_p.h" or better ), now all the private headers of the UITK can
    be included by the users withour compilation issues. It also removes a bunch
    of direct includes from sources and a few INCLUDEPATHs hacks.See the CODING
    file for more details.
  * Cleaned up ubuntu_qt_module.prf and the libs using it.
    1/ Moved the common config options from the pro files to the prf file to
       avoid duplications and simplify the files.
    2/ Removed the useless "TEMPLATE=lib" and "load(qt_build_config)" lines from
       the pro files since it's done for us by qt_module.prf.
    3/ Use QT= instead of QT*= since it's well defined that by default its
       content is "core gui".
    4/ Prefixed headers and sources by $$PWD/ and sorted the lines
       alphabetically.
    5/ Merged the SOURCES declarations in UbuntuToolkit.pro.
    6/ Removed the useless "DEFINES += QT_USE_QSTRINGBUILDER" line from
       UbuntuToolkit.pro since it's done for us by qt_module.prf.
    7/ Removed the useless "QMAKE_CXXFLAGS -= -Werror=deprecated-declarations"
       and "DEFINES -= QT_DEPRECATED_WARNINGS" lines from UbuntuToolkit.pro
       since it's already done in ubuntu_qt_module.prf.
    8/ Added a few comments.
  * Made use of Qt builtin to check GCC version.

  [ Tim Peeters ]
  * Improve the initialization of Action when it gets both iconName and
    iconSource from an external component when iconSource is undefined. This
    fixes the some times missing overflow button in the ActionBar with Qt 5.6.
    I also removed action: modelData from the OverflowPanel because this is
    a...

Read more...

Changed in ubuntu-ui-toolkit (Ubuntu RTM):
status: In Progress → Fix Released
Changed in canonical-devices-system-image:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.