Crash when accessing a preview in the uapp explorer scope
Bug #1581495 reported by
Albert Astals Cid
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
Undecided
|
Unassigned | ||
unity-scopes-shell (Ubuntu) |
Fix Released
|
High
|
Paweł Stołowski |
Bug Description
When trying to access a preview in the uapp explorer scope it, unity8-dash crashes
Backtrace: http://
Related branches
lp:~stolowski/unity-scopes-shell/fix-1581495
- Marcus Tomlinson (community): Approve
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
-
Diff: 112 lines (+65/-1)3 files modifiedsrc/Unity/previewmodel.cpp (+5/-1)
tests/data/mock-scope/mock-scope.cpp (+18/-0)
tests/previewtest.cpp (+42/-0)
description: | updated |
Changed in unity-scopes-shell (Ubuntu): | |
assignee: | nobody → Pawel Stolowski (stolowski) |
Changed in canonical-devices-system-image: | |
status: | New → Confirmed |
Changed in unity-scopes-shell (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in unity-scopes-shell (Ubuntu): | |
importance: | Undecided → High |
Changed in canonical-devices-system-image: | |
status: | Confirmed → Fix Released |
To post a comment you must log in.
Ok, the scope has a bug as it pushed two widgets with same ID on preview. Obviously we shouldn't crash, so that needs to be handled. Respective snipper of unity8-dash.log when this happens:
--- Widget lookups dump "addReplaceWidget" --- :addWidgetToCol umnModel( ): processing widget "author" :addWidgetToCol umnModel( ): destination for widget "author" is row 7 , column 0 del::moveWidget (): invalid destRow 7
Widget "header" at position 0 , lookup index 0
Widget "art" at position 1 , lookup index 1
Widget "types" at position 2 , lookup index 2
Widget "author" at position 3 , lookup index 3
Widget "hearts" at position 4 , lookup index 4
Widget "stars" at position 5 , lookup index 5
Widget "actions" at position 6 , lookup index 6
PreviewModel:
PreviewModel:
PreviewWidgetMo
The offending widgets are authorWidget and moreWidget in this code, both with "author" id: https:/ /github. com/bhdouglass/ uappexplorer- scope/blob/ master/ src/uappexplore r-scope. go