Need support for dynamic grid units
Bug #1573532 reported by
Michał Sawicz
This bug affects 4 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
Critical
|
Michał Sawicz | ||
qtmir (Ubuntu) |
Fix Released
|
Critical
|
Gerry Boland | ||
qtubuntu (Ubuntu) |
Fix Released
|
Critical
|
Gerry Boland | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Critical
|
Gerry Boland |
Bug Description
Different screens have different DPIs, we need to adapt so that UI elements scale to the screen.
Related branches
lp:~unity-team/ubuntu-ui-toolkit/dynamic-grid-unit
- ubuntu-sdk-build-bot: Approve (continuous-integration)
- Cris Dywan: Approve
-
Diff: 146 lines (+31/-15)7 files modifiedsrc/Ubuntu/Components/1.3/OptionSelectorDelegate.qml (+1/-1)
src/Ubuntu/Components/Themes/Ambiance/1.3/PageHeaderStyle.qml (+7/-7)
src/Ubuntu/Components/Themes/Ambiance/1.3/SheetForegroundStyle.qml (+1/-1)
src/Ubuntu/Components/plugin/label_p.h (+0/-1)
src/Ubuntu/Components/plugin/uclabel.cpp (+3/-5)
src/Ubuntu/Components/plugin/uclabel.h (+1/-0)
tests/unit/tst_components/tst_label13.qml (+18/-0)
- Michał Sawicz: Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Tim Peeters: Needs Information
- Cris Dywan: Needs Fixing
-
Diff: 146 lines (+31/-15)7 files modifiedsrc/Ubuntu/Components/1.3/OptionSelectorDelegate.qml (+1/-1)
src/Ubuntu/Components/Themes/Ambiance/1.3/PageHeaderStyle.qml (+7/-7)
src/Ubuntu/Components/Themes/Ambiance/1.3/SheetForegroundStyle.qml (+1/-1)
src/Ubuntu/Components/plugin/label_p.h (+0/-1)
src/Ubuntu/Components/plugin/uclabel.cpp (+3/-5)
src/Ubuntu/Components/plugin/uclabel.h (+1/-0)
tests/unit/tst_components/tst_label13.qml (+18/-0)
lp:~unity-team/qtmir/set-display-config
- Unity8 CI Bot (community): Approve (continuous-integration)
- Daniel d'Andrada (community): Approve
- Albert Astals Cid (community): Needs Information
-
Diff: 2693 lines (+1103/-235)47 files modifieddemos/qml-demo-shell/Button.qml (+26/-0)
demos/qml-demo-shell/qml-demo-shell.qml (+22/-3)
src/modules/Unity/Application/application_manager.cpp (+1/-1)
src/modules/Unity/Application/mirsurface.cpp (+11/-0)
src/modules/Unity/Application/mirsurface.h (+2/-0)
src/modules/Unity/Application/mirsurfaceinterface.h (+3/-1)
src/modules/Unity/Application/mirsurfaceitem.cpp (+23/-2)
src/modules/Unity/Application/mirsurfaceitem.h (+3/-1)
src/modules/Unity/Application/mirsurfacemanager.cpp (+2/-2)
src/modules/Unity/Application/sessionmanager.cpp (+2/-2)
src/modules/Unity/Screens/CMakeLists.txt (+5/-0)
src/modules/Unity/Screens/plugin.cpp (+5/-1)
src/modules/Unity/Screens/qquickscreenwindow.cpp (+185/-0)
src/modules/Unity/Screens/qquickscreenwindow.h (+60/-0)
src/modules/Unity/Screens/screens.cpp (+24/-5)
src/modules/Unity/Screens/screens.h (+16/-2)
src/platforms/mirserver/CMakeLists.txt (+3/-2)
src/platforms/mirserver/customscreenconfiguration.h (+41/-0)
src/platforms/mirserver/mirdisplayconfigurationpolicy.cpp (+64/-7)
src/platforms/mirserver/mirdisplayconfigurationpolicy.h (+8/-7)
src/platforms/mirserver/mirserver.cpp (+13/-13)
src/platforms/mirserver/mirserver.h (+7/-5)
src/platforms/mirserver/mirserverintegration.cpp (+16/-7)
src/platforms/mirserver/nativeinterface.cpp (+55/-4)
src/platforms/mirserver/nativeinterface.h (+11/-4)
src/platforms/mirserver/qmirserver.cpp (+18/-10)
src/platforms/mirserver/qmirserver.h (+5/-3)
src/platforms/mirserver/qmirserver_p.h (+5/-3)
src/platforms/mirserver/qteventfeeder.cpp (+11/-11)
src/platforms/mirserver/qteventfeeder.h (+5/-5)
src/platforms/mirserver/screen.cpp (+79/-12)
src/platforms/mirserver/screen.h (+20/-3)
src/platforms/mirserver/screenscontroller.cpp (+84/-0)
src/platforms/mirserver/screenscontroller.h (+54/-0)
src/platforms/mirserver/screensmodel.cpp (+87/-45)
src/platforms/mirserver/screensmodel.h (+7/-4)
src/platforms/mirserver/screenwindow.cpp (+23/-7)
src/platforms/mirserver/screenwindow.h (+3/-1)
tests/framework/fake_mirsurface.h (+2/-0)
tests/framework/qtmir_test.cpp (+2/-2)
tests/mirserver/CMakeLists.txt (+1/-1)
tests/mirserver/QtEventFeeder/mock_qtwindowsystem.h (+1/-1)
tests/mirserver/QtEventFeeder/qteventfeeder_test.cpp (+2/-2)
tests/mirserver/ScreensModel/CMakeLists.txt (+5/-5)
tests/mirserver/ScreensModel/screensmodel_test.cpp (+47/-47)
tests/mirserver/ScreensModel/stub_displayconfigurationcontroller.h (+30/-0)
tests/mirserver/ScreensModel/testable_screensmodel.h (+4/-4)
lp:~unity-team/qtubuntu/screen-info-without-dpr
- Unity8 CI Bot: Approve (continuous-integration)
- Daniel d'Andrada (community): Approve
- Gerry Boland (community): Approve
- Nick Dedekind (community): Approve
-
Diff: 1849 lines (+874/-341)15 files modifiedsrc/ubuntumirclient/glcontext.cpp (+141/-32)
src/ubuntumirclient/glcontext.h (+9/-7)
src/ubuntumirclient/input.cpp (+103/-52)
src/ubuntumirclient/input.h (+3/-1)
src/ubuntumirclient/integration.cpp (+81/-19)
src/ubuntumirclient/integration.h (+33/-7)
src/ubuntumirclient/nativeinterface.cpp (+61/-14)
src/ubuntumirclient/nativeinterface.h (+16/-5)
src/ubuntumirclient/screen.cpp (+113/-150)
src/ubuntumirclient/screen.h (+26/-15)
src/ubuntumirclient/screenobserver.cpp (+137/-0)
src/ubuntumirclient/screenobserver.h (+54/-0)
src/ubuntumirclient/ubuntumirclient.pro (+2/-0)
src/ubuntumirclient/window.cpp (+74/-31)
src/ubuntumirclient/window.h (+21/-8)
lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/trunk-fix-icon-svg-image-loading
Rejected
for merging
into
lp:ubuntu-ui-toolkit/staging
- Michał Sawicz: Disapprove
- ubuntu-sdk-build-bot: Approve (continuous-integration)
-
Diff: 280 lines (+77/-66)3 files modifiedsrc/Ubuntu/Components/plugin/unitythemeiconprovider.cpp (+61/-51)
src/Ubuntu/Components/plugin/unitythemeiconprovider.h (+1/-1)
tests/unit_x11/tst_iconprovider/tst_iconprovider.cpp (+15/-14)
- Tim Peeters: Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
-
Diff: 316 lines (+96/-66)4 files modifiedsrc/Ubuntu/Components/plugin/unitythemeiconprovider.cpp (+61/-51)
src/Ubuntu/Components/plugin/unitythemeiconprovider.h (+1/-1)
tests/unit_x11/tst_components/tst_icon.qml (+19/-0)
tests/unit_x11/tst_iconprovider/tst_iconprovider.cpp (+15/-14)
lp:~lukas-kde/ubuntu-ui-toolkit/staging-fix-icon-svg-image-loading
- ubuntu-sdk-build-bot: Approve (continuous-integration)
- Tim Peeters: Approve
-
Diff: 318 lines (+96/-66)4 files modifiedsrc/Ubuntu/Components/plugin/unitythemeiconprovider.cpp (+61/-51)
src/Ubuntu/Components/plugin/unitythemeiconprovider.h (+1/-1)
tests/unit_x11/tst_components/tst_icon.qml (+19/-0)
tests/unit_x11/tst_iconprovider/tst_iconprovider.cpp (+15/-14)
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | New → In Progress |
assignee: | nobody → Gerry Boland (gerboland) |
importance: | Undecided → Critical |
Changed in qtubuntu (Ubuntu): | |
status: | New → Fix Committed |
status: | Fix Committed → In Progress |
Changed in qtmir (Ubuntu): | |
status: | New → In Progress |
importance: | Undecided → Critical |
Changed in qtubuntu (Ubuntu): | |
importance: | Undecided → Critical |
Changed in qtmir (Ubuntu): | |
assignee: | nobody → Gerry Boland (gerboland) |
Changed in qtubuntu (Ubuntu): | |
assignee: | nobody → Gerry Boland (gerboland) |
Changed in canonical-devices-system-image: | |
status: | In Progress → Fix Committed |
Changed in qtmir (Ubuntu): | |
status: | In Progress → Fix Released |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | In Progress → Fix Released |
Changed in qtubuntu (Ubuntu): | |
status: | In Progress → Fix Released |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.