[indicators] Players in sound indicator are not launched when clicking in its icon

[Xavi Garcia]

The sound indicator defines an action per each player.

Example for music-app on the phone:
 struct {
         uint32 1
         uint32 2
         array [
            array [
               dict entry(
                  string "action"
                  variant string "indicator.mediaplayer-app.desktop"
               )

I don't see on the phone that the action is invoked when pressing the app icon, so the app cannot be raised or launched from the indicator.

This works fine in unity7 (desktop).

[Lukáš Tinkl (lukas-kde)]

The applications are usually launched by the indicator itself; sounds like a bug in indicator-sound to me

[Lukáš Tinkl (lukas-kde)]

From indicator-sound source code:

media-player-mpris.vala:

    /**
     * Activate the associated media player.
     *
     * Note: this will _not_ call attach(), because it doesn't know on which dbus-name the player will appear.
     * Use attach() to attach this object to a running instance of the player.
     */
    public override void activate () {
        try {
            if (this.proxy == null) {
                this.appinfo.launch (null, null);
                this.state = "Launching";
            }
            else if (this.root != null && this.root.CanRaise) {
                this.root.Raise ();
            }
        }
        catch (Error e) {
            warning ("unable to activate %s: %s", appinfo.get_name (), e.message);
        }
    }

media-player-user.vala:

    public override void activate () {
        /* TODO: */
    }

[Xavi Garcia (xavi-garcia-mena)]

The music-app is an MPRIS player (running the code from media-player-mpris.vala:)

That code is running on the desktop (unity7) and it launches the players fine.

That's why I've opened the bug, to also confirm the action associated with the player is executed.
I've asked dednick about it and he wasn't 100% sure if it was a unity8 bug.

Cheers

[Xavi Garcia (xavi-garcia-mena)]

I cannot see any action with dbus-monitor being invoked when pressing the app icon.

I'm moving this as Invalid for the indicator, please feel free to reopen if you conclude there's nothing wrong in unity8.

[Lukáš Tinkl (lukas-kde)]

After more investigation, I found out the root of this bug: what you see in the indicator is the Media Player (the video app) which cannot play audio. On the other hand, what would be useful to display here, is the Music app (which sadly doesn't have this DBUS-MPRIS functionality.

[Xavi Garcia (xavi-garcia-mena)]

I see, thanks a lot for finding this out!...
But in that case... I'm wondering if the icon should launch the media-app instead.

[Michael Zanetti (mzanetti)]

The buttons in the indicator are provided by media-hub.

Media-hub should launch the application that caused it to register those buttons. Probably falling back to the default music application.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Pat McGowan (pat-mcgowan)]

The metadata is displayed properly now,