Removed clicks come back on OTA update

[Alan Pope 🍺🐧🐱 🦄]

I have a krillin which was on OTA8.5.
I removed every single click on the device, so all that's left are the deb based apps (phone, browser, contacts, messaging, system settings and sd card thing).

I had removed all the clicks using "sudo click unregister foo 1.0" for each click.

I updated to OTA9 and loads of previously removed apps have come back.

This should not happen (IMO).

Attached screenshot showing the applications which came back.

[Pat McGowan (pat-mcgowan)]

All the preinstalled apps in the custom tarball are restored. Its a bit of a hole in the design that I am not sure how to close.

[Jean-Baptiste Lallement (jibel)]

It seems to be part of the original click databases design [1] and taken into consideration from day 1.

"[...]
There was an idea early on that we'd deal with preinstalled apps by going
round and registering them all for all active users on first boot. This
would have lots of problems for the packaging system, though. Most notably,
doing it that way makes it hard for a user to remove an app and make it
stick, *because it would tend to reappear on system updates*.
[...]"

Understanding why the original idea is not part of the current implementation would be a good starting point IMHO.

[1] http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/vivid/click/vivid/view/head:/doc/databases.rst

[Colin Watson (cjwatson)]

My original design and implementation explicitly did not suffer from this flaw; the @hidden links account for this. I initially thought that the changes made in bug 1479001 were responsible for this bug because this is the type of conflicting requirement I expected to be caused by those changes; but I've just looked through the code and I don't in fact see how it could cause this particular symptom.

Could I get the output of "find /usr/share/click/preinstalled/ /custom/click/ /opt/click.ubuntu.com/ -ls" at each of the following stages:

 * initial installation of OTA8.5
 * after running "sudo click unregister" on the list of apps in question (BTW, you don't need "sudo" here, but it shouldn't hurt since we check $SUDO_USER)
 * after applying OTA9