Canonical System Image

Previews don't support two columns layout

Bug #1536372 reported by Andrea Cimitan on 2016-01-20

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Canonical Pocket Desktop	Confirmed	High	Unassigned
Canonical System Image	Fix Committed	High	Alejandro J. Cura	Canonical System Image 9.5 "OTA.5"
Ubuntu Rest Scopes	New	Undecided	Unassigned
Ubuntu UX	Triaged	Undecided	Paty Davila
unity-scope-click (Ubuntu)	Fix Released	Critical	Paweł Stołowski
unity-scopes-api (Ubuntu)	Invalid	Undecided	Unassigned

Bug Description

Just try the previews using this scope on ore than 80gu width, like on a landscape tablet. We see one single column half side of the screen. It should use both columns to display content. Mediascanner scope (and Youtube too) for example are working as expected

Related branches

lp:~stolowski/unity-scope-click/two-columns-layout

Merged into lp:unity-scope-click at revision 407

PS Jenkins bot: Needs Fixing (continuous-integration) on 2016-01-28

dobey (community): Approve on 2016-01-28

Andrea Cimitan (cimi) on 2016-01-20

no longer affects:

7digital (Ubuntu)

Revision history for this message

dobey (dobey) wrote on 2016-01-20:

Can you please provide screenshots? We'll also need design input for how the layout should be.

Changed in unity-scope-click (Ubuntu):
importance:	Undecided → High
status:	New → Incomplete

Andrea Cimitan (cimi) on 2016-01-20

no longer affects:	7digital (Ubuntu)
Changed in unity-scope-click (Ubuntu):
status:	Incomplete → New

Revision history for this message

Andrea Cimitan (cimi) wrote on 2016-01-20:

file.jpg Edit (222.5 KiB, image/jpeg)

Pat McGowan (pat-mcgowan) on 2016-01-21

Changed in canonical-devices-system-image:
assignee:	nobody → Alejandro J. Cura (alecu)
importance:	Undecided → High
milestone:	none → ww04-2016
status:	New → Confirmed
Changed in canonical-pocket-desktop:
status:	New → Confirmed
importance:	Undecided → High

dobey (dobey) on 2016-01-21

no longer affects:	unity-scopes-api (Ubuntu)
Changed in unity-scope-click (Ubuntu):
importance:	High → Critical
assignee:	nobody → Pawel Stolowski (stolowski)
status:	New → Triaged

Paweł Stołowski (stolowski) on 2016-01-21

Changed in unity-scope-click (Ubuntu):
status:	Triaged → In Progress

Revision history for this message

Paty Davila (dizzypaty) wrote on 2016-01-22:

Card preview layouts should allow users to scan quickly through the main useful information, take instant actions (e.g.: tap on the ‘call item’ will trigger the phone app) and explore more related information (such as comments, reviews, other cards recommendations, etc.) if they decide to dive into the details of the card.

In this case, where we need to divide this preview content into two columns, I’d suggest to place the app main info (mascot, title, subtitle) and buttons, as well as the image gallery on the left hand side, followed by the review widget. Info tables should go on the right.

Revision history for this message

Victor Tuson Palau (vtuson) wrote on 2016-01-22:

the scope author needs to define scope layouts for 2 and 3 columns on the preview. Can you specify if this is supported for remote scopes?

Revision history for this message

Paweł Stołowski (stolowski) wrote on 2016-01-22:

@Victor it's implemented but was never actually truly used and in fact I can already see a bug in smartscopesproxy that will break it when remote scope returns category layouts. Will be easy to fix. Adding unity-scopes-api to the bug report.

Revision history for this message

Michi Henning (michihenning) wrote on 2016-01-22:

Pawel and I just looked at it and there is no bug in scopes-api after all. As best as we can tell, as long as the remote scope requests two columns, things will just work.

Marking as invalid for scopes-api.

Changed in unity-scopes-api (Ubuntu):
status:	New → Invalid

Revision history for this message

Launchpad Janitor (janitor) wrote on 2016-01-30:

This bug was fixed in the package unity-scope-click - 0.1.1+16.04.20160128-0ubuntu1

---------------
unity-scope-click (0.1.1+16.04.20160128-0ubuntu1) xenial; urgency=medium

[ Pawel Stolowski ]
* Support two column layouts in the previews. (LP: #1536372)

  [ Rodney Dawes ]
  * Avoid a race and crash by unlinking the callback inside the
    callback. (LP: #1486287)
  * Only try to parse the JSON when we get a 200. (LP: #1531656)
  * Remove reference to click in translated strings. (LP: #1536252)

-- Rodney Dawes <email address hidden> Thu, 28 Jan 2016 15:03:56 +0000